Re: Bugs and regressions in .Bk

[Kristaps Dzonsons <kristaps@bsd.lv>]

On 06/02/2011 21:39, Ingo Schwarze wrote:
> Hi Kristaps,
>
>> Log Message:
>> -----------
>> Arguments to `Bsx' and friends are separated by a non-breaking space.
>> This removes a TODO raised by schwarze@.
>
> While trying to merge this patch, i ran into a regression:
> When called inside .Bk or in the SYNOPSIS, this patch ends
> keep mode.
>
> Trying to fix that (meanwhile, i have a working fix, so don't
> waste your time searching for it), i ran into another .Bk bug:
> For text generated in the pre-handler, setting up keep state
> comes too late to take effect.
>
> So, my plan is to
>
>   1) Get the following patch in, fixing the latter bug - OK?
>      The code is unchanged, it is just moved around.
>
>   2) Once that's in, merge your patch to OpenBSD, together
>      with my fix for the regression.
>
>   3) Finally, merge back my regression fix to bsd.lv.

Ingo,

That's fine by me.  I haven't closely examined the behaviour, but it 
looks reasonable.  Please add in the necessary comments in the code as 
to why the order is important, though...

Thanks!

Kristaps

--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv