Re: [PATCH] \*(Px and \*(Ai

[Kristaps Dzonsons <kristaps@bsd.lv>]

[-- Attachment #1: Type: text/plain, Size: 889 bytes --]

On 20/04/2011 14:52, Jason McIntyre wrote:
> On Wed, Apr 20, 2011 at 01:46:19PM +0200, Kristaps Dzonsons wrote:
>> Hi,
>>
>> As discussed on tech@openbsd.org,
>>
>> http://comments.gmane.org/gmane.os.openbsd.tech/24663
>>
>> we're missing two symbols defined in tmac.doc.  The enclosed patch
>> includes them (not the documentation bits for mandoc_char.7, which I'd
>> include if this is ok'd).
>>
>> For the record, I don't particularly like these as they discourage using
>> `St' in favour of hand-rolling standards.  I think this should be taken
>> into account when deciding on whether to ok this.
>>
>> So... thoughts?
>>
>> Kristaps
>
> i personally don;t care. i can remove the one instance of Px if that's
> what we prefer. i certainly don;t want Px and Ai all over the manuals.

Enclosed is a patch with the documentation.  I think this is good enough 
to discourage usage.  Oks?

[-- Attachment #2: patch.chars.txt --]
[-- Type: text/plain, Size: 2138 bytes --]

Index: chars.c
===================================================================
RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/chars.c,v
retrieving revision 1.34
diff -u -r1.34 chars.c
--- chars.c	22 Mar 2011 10:13:01 -0000	1.34
+++ chars.c	20 Apr 2011 20:09:29 -0000
@@ -41,7 +41,7 @@
 #define CHARS_BOTH	 (CHARS_CHAR | CHARS_STRING)
 };
 
-#define	LINES_MAX	  351
+#define	LINES_MAX	  353
 
 #define CHAR(in, ch, code) \
 	{ NULL, (in), (ch), (code), CHARS_CHAR },
Index: chars.in
===================================================================
RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/chars.in,v
retrieving revision 1.36
diff -u -r1.36 chars.in
--- chars.in	16 Mar 2011 22:49:55 -0000	1.36
+++ chars.in	20 Apr 2011 20:09:29 -0000
@@ -375,6 +375,8 @@
 STRING("right-singlequote",	"\'",		8217)
 STRING("rp",			")",		41)
 STRING("Tm",			"(Tm)",		8482)
+STRING("Px",			"POSIX",	0)
+STRING("Ai",			"ANSI",		0)
 
 /* Lines. */
 CHAR("ba",			"|",		124)
Index: mandoc_char.7
===================================================================
RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/mandoc_char.7,v
retrieving revision 1.42
diff -u -r1.42 mandoc_char.7
--- mandoc_char.7	9 Feb 2011 22:53:20 -0000	1.42
+++ mandoc_char.7	20 Apr 2011 20:09:30 -0000
@@ -481,8 +481,12 @@
 .It \e(ts    Ta \(ts        Ta sigma terminal
 .El
 .Sh PREDEFINED STRINGS
-These are not recommended for use, as they differ across
-implementations:
+Predefined strings are inherited from the macro packages of historical
+troff implementations.
+They are
+.Em not recommended
+for use, as they differ across implementations.
+Manuals using these predefined macros are almost certainly not portable.
 .Pp
 .Bl -column -compact -offset indent "Input" "Rendered" "Description"
 .It Em Input Ta Em Rendered Ta Em Description
@@ -512,6 +516,8 @@
 .It \e*(>=   Ta \*(>=       Ta greater-than-equal
 .It \e*(aa   Ta \*(aa       Ta acute
 .It \e*(ga   Ta \*(ga       Ta grave
+.It \e*(Px   Ta \*(Px       Ta POSIX standard name
+.It \e*(Ai   Ta \*(Ai       Ta ANSI standard name
 .El
 .Sh NUMBERED CHARACTERS
 For backward compatibility with existing manuals,