Re: [PATCH] \*(Px and \*(Ai

[Kristaps Dzonsons <kristaps@bsd.lv>]

>> Enclosed is a patch with the documentation.  I think this is good
>> enough to discourage usage.  Oks?
>
> Yes, i agree we should have them for backward compatibility,
> warning would be rather messy right now, and the documentation
> should strongly discourage them.
>
> Thus, OK, except for one nit inline.
>
> Yours,
>    Ingo
>
>> Index: chars.c
>> ===================================================================
>> RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/chars.c,v
>> retrieving revision 1.34
>> diff -u -r1.34 chars.c
>> --- chars.c	22 Mar 2011 10:13:01 -0000	1.34
>> +++ chars.c	20 Apr 2011 20:09:29 -0000
>> @@ -41,7 +41,7 @@
>>   #define CHARS_BOTH	 (CHARS_CHAR | CHARS_STRING)
>>   };
>>
>> -#define	LINES_MAX	  351
>> +#define	LINES_MAX	  353
>>
>>   #define CHAR(in, ch, code) \
>>   	{ NULL, (in), (ch), (code), CHARS_CHAR },
>> Index: chars.in
>> ===================================================================
>> RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/chars.in,v
>> retrieving revision 1.36
>> diff -u -r1.36 chars.in
>> --- chars.in	16 Mar 2011 22:49:55 -0000	1.36
>> +++ chars.in	20 Apr 2011 20:09:29 -0000
>> @@ -375,6 +375,8 @@
>>   STRING("right-singlequote",	"\'",		8217)
>>   STRING("rp",			")",		41)
>>   STRING("Tm",			"(Tm)",		8482)
>> +STRING("Px",			"POSIX",	0)
>> +STRING("Ai",			"ANSI",		0)
>>
>>   /* Lines. */
>>   CHAR("ba",			"|",		124)
>> Index: mandoc_char.7
>> ===================================================================
>> RCS file: /usr/vhosts/mdocml.bsd.lv/cvs/mdocml/mandoc_char.7,v
>> retrieving revision 1.42
>> diff -u -r1.42 mandoc_char.7
>> --- mandoc_char.7	9 Feb 2011 22:53:20 -0000	1.42
>> +++ mandoc_char.7	20 Apr 2011 20:09:30 -0000
>> @@ -481,8 +481,12 @@
>>   .It \e(ts    Ta \(ts        Ta sigma terminal
>>   .El
>>   .Sh PREDEFINED STRINGS
>> -These are not recommended for use, as they differ across
>> -implementations:
>> +Predefined strings are inherited from the macro packages of historical
>> +troff implementations.
>> +They are
>> +.Em not recommended
>> +for use, as they differ across implementations.
>> +Manuals using these predefined macros are almost certainly not portable.
>
> That should read "... using these predefined *strings*...".
> Those are not macros.

Ooops!  Ingo, thanks for the lookover---I'll commit a fixed version of 
this in a few.

Kristaps
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv