Re: tbl issues with 1.11.1

[Kristaps Dzonsons <kristaps@bsd.lv>]

On 20/09/2011 19:32, Ingo Schwarze wrote:
> Hi,
>
> Ingo Schwarze wrote on Sat, May 14, 2011 at 06:12:28AM +0200:
>
>> Getting this right in both cases - with and without vertical rulers -
>> requires rather large changes.  The logic, as far as i understand it
>> so far, goes like this:
>>
>>   - box produces "|"
>>   - no spacing at this point
>>   - first cell, width is max(lengths)
>>   - one space
>>   - vertical ruler, if none, another space
>>   - another space, unless there was a double ruler (!!)
>>   - second cell
>>   - and so on.
>>
>> That is vastly different from what we have now, both regarding the
>> width calculations - which apparently must not include padding - and
>> regarding the output itself.
>>
>> The work-in-progress patch below comes closer.  However, it still
>> has at least two deficiencies, so it is not ready for commit:
>>   - There still is a bogus space after double rulers, see (!!).
>>   - The handling of explicit spacing options got sweeped away
>>     by the reorg i was forced to do.  Probably, i need to put
>>     it back in at the right places.  It was in the calc routine
>>     but probably belongs in the output routines themselves.
>
> I now have an updated diff that i consider ripe for commit,
> which is improved in four respects:
>    - do not use spanned cells for width calculations
>    - draw horizontal rulers of the right width
>    - correctly draw horizontal frames
>    - guard against integer underflow in tbl_literal
>
> As explicit spacing options seem to be used very rarely, if at all,
> i have left them out for now to not make the diff yet larger.
>
> OK?
>    Ingo

Ingo,

This looks ok---the table output formatting has always been spotty. 
Please check this in (I like the in-line documentation you have, but the 
more the better, as this area's tricksy).

Thanks!

Kristaps
--
 To unsubscribe send an email to tech+unsubscribe@mdocml.bsd.lv