[PR PATCH] Use tolower instead of lc

[PR PATCH] Use tolower instead of lc

[rheoli]

[-- Attachment #1: Type: text/plain, Size: 390 bytes --]

There is a new pull request by rheoli against master on the mblaze repository

https://github.com/rheoli/mblaze master
https://github.com/leahneukirchen/mblaze/pull/235

Use tolower instead of lc
Use tolower instead of lc as there are some M365 header with _ in the name of headers (example msip_label).

A patch file from https://github.com/leahneukirchen/mblaze/pull/235.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-235.patch --]
[-- Type: text/x-diff, Size: 821 bytes --]

From 417847fd89af92fb8c2a6908df264bcd8db485f6 Mon Sep 17 00:00:00 2001
From: Stephan Toggweiler <609601+rheoli@users.noreply.github.com>
Date: Thu, 16 Mar 2023 17:36:05 +0100
Subject: [PATCH] use tolower instead of lc as there are some M365 header with
 _ in the name of headers

---
 blaze822.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/blaze822.c b/blaze822.c
index 47f03a2..b960b0b 100644
--- a/blaze822.c
+++ b/blaze822.c
@@ -396,7 +396,7 @@ unfold_hdr(char *buf, char *end)
 	s = buf;
 
 	while (s < end && *s != ':' && *s != '\n') {
-		*s = lc(*s);
+		*s = tolower(*s);
 		s++;
 	}
 
@@ -412,7 +412,7 @@ unfold_hdr(char *buf, char *end)
 			compress_hdr(l, s-1);
 			l = s;
 			while (s < end && *s != ':' && *s != '\n') {
-				*s = lc(*s);
+				*s = tolower(*s);
 				s++;
 			}
 		}

Re: Use tolower instead of lc

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 276 bytes --]

New comment by leahneukirchen on mblaze repository

https://github.com/leahneukirchen/mblaze/pull/235#issuecomment-1472534922

Comment:
The issue is correct, but we can't use tolower here since it's locale dependent and some libc do weird stuff then.
I'll add a guard to lc.

Re: [PR PATCH] [Closed]: Use tolower instead of lc

[leahneukirchen]

[-- Attachment #1: Type: text/plain, Size: 254 bytes --]

There's a closed pull request on the mblaze repository

Use tolower instead of lc
https://github.com/leahneukirchen/mblaze/pull/235

Description:
Use tolower instead of lc as there are some M365 header with _ in the name of headers (example msip_label).