Github messages for mblaze
 help / color / mirror / Atom feed
From: rakoo <rakoo@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] Improve attachments handling
Date: Sat, 11 Nov 2023 03:07:58 +0100	[thread overview]
Message-ID: <20231111020758.otGdS0uGbjl891hPlNdneokXyhTNeF2R-AEWBaMBl6c@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-fa6558a0-26e0-48f6-803f-f5a8af34f6a8-mblaze-234@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 624 bytes --]

There is an updated pull request by rakoo against master on the mblaze repository

https://github.com/rakoo/mblaze master
https://github.com/leahneukirchen/mblaze/pull/234

Improve attachments handling
I had to manually explore to understand how to add attachments, the man page was a bit evasive. It also didn't help that a `~` at the beginning of the path isn't caught, so I added the same treatment as outbox parsing.

Thanks for this fantastic piece of software, the joys of building one's own MUA in ~150 lines of shell scripts...

A patch file from https://github.com/leahneukirchen/mblaze/pull/234.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-234.patch --]
[-- Type: text/x-diff, Size: 798 bytes --]

From f17006eeb909f2a881ebf155485c3fb703fc5825 Mon Sep 17 00:00:00 2001
From: Matthieu Rakotojaona <m@rako.space>
Date: Sat, 11 Nov 2023 02:01:19 +0100
Subject: [PATCH] Attach all files when forwarding in raw mode

---
 mcom | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/mcom b/mcom
index 4e834c6..7981f65 100755
--- a/mcom
+++ b/mcom
@@ -306,6 +306,18 @@ fi
 		msgid
 		museragent
 		cat "$MBLAZE/headers" 2>/dev/null
+		if [ -n "$raw" ]; then
+			prev=$(pwd)
+			attachdir=$(mktemp -d)
+			cd $attachdir
+			mseq -r "$@" \
+				| xargs -I {} mshow -Bx {} \
+				| IFS=$NL xargs realpath \
+				| sed 's/^/Attach: /'
+			cd $prev
+			trap 'rm -r "$attachdir"' EXIT
+		fi
+
 		printf '\n\n'
 		if [ -z "$raw" ]; then
 			mseq -r "$@" | sed 's:^:#message/rfc822#inline :; s:$:>:'

  parent reply	other threads:[~2023-11-11  2:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-27 14:39 [PR PATCH] " rakoo
2023-02-27 14:47 ` leahneukirchen
2023-04-12 14:45 ` [PR PATCH] [Updated] " rakoo
2023-05-23 22:47 ` Eolien55
2023-11-11  2:07 ` rakoo [this message]
2023-11-24 12:55 ` [PR PATCH] [Updated] " rakoo
2024-04-24 16:51 ` rakoo
2024-04-24 16:54 ` rakoo
2024-04-24 16:58 ` rakoo
2024-04-24 17:02 ` [PR PATCH] [Closed]: " rakoo
2024-04-24 17:02 ` rakoo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231111020758.otGdS0uGbjl891hPlNdneokXyhTNeF2R-AEWBaMBl6c@z \
    --to=rakoo@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).