Github messages for mblaze
 help / color / mirror / Atom feed
From: ndalliard <ndalliard@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [ISSUE] fallback to $VISUAL
Date: Wed, 21 Apr 2021 14:59:50 +0200
Message-ID: <gh-mailinglist-notifications-fa6558a0-26e0-48f6-803f-f5a8af34f6a8-mblaze-206@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 734 bytes --]

New issue by ndalliard on mblaze repository

https://github.com/leahneukirchen/mblaze/issues/206

Description:
I would suggest `EDITOR="${VISUAL:-${EDITOR:-vi}}"` in [mcom](https://github.com/leahneukirchen/mblaze/blob/e8981b723d35c530ef217140c965287ecd0e9031/mcom#L496) instead of only `${EDITOR:-vi}`.

On OpenBSD in `man ksh` it says under `EDITOR`:

````
                Note: traditionally, EDITOR was used to specify the name of
                an (old-style) line editor, such as ed(1), and VISUAL was
                used to specify a (new-style) screen editor, such as vi(1).
                Hence if VISUAL is set, it overrides EDITOR.
````

Can create a pull request if appreciated. Thanks for the great work!


             reply	other threads:[~2021-04-21 12:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-21 12:59 ndalliard [this message]
2021-04-21 13:10 ` [ISSUE] [CLOSED] " leahneukirchen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-fa6558a0-26e0-48f6-803f-f5a8af34f6a8-mblaze-206@inbox.vuxu.org \
    --to=ndalliard@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Github messages for mblaze

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.vuxu.org/mblaze-github

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 mblaze-github mblaze-github/ https://inbox.vuxu.org/mblaze-github \
		mblaze-github@inbox.vuxu.org
	public-inbox-index mblaze-github

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.github.mblaze


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git