From: WANG Xuerui <kernel@xen0n.name>
To: Arnd Bergmann <arnd@kernel.org>, Huacai Chen <chenhuacai@kernel.org>
Cc: musl@lists.openwall.com, WANG Xuerui <kernel@xen0n.name>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-arch <linux-arch@vger.kernel.org>,
GNU C Library <libc-alpha@sourceware.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Peter Zijlstra <peterz@infradead.org>,
Marc Zyngier <maz@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Jianmin Lv <lvjianmin@loongson.cn>,
linux-pci <linux-pci@vger.kernel.org>,
Ard Biesheuvel <ardb@kernel.org>,
Huacai Chen <chenhuacai@loongson.cn>
Subject: Re: [musl] Re: [GIT PULL] asm-generic changes for 5.19
Date: Wed, 1 Jun 2022 08:41:42 +0800 [thread overview]
Message-ID: <1dbaed5d-fb83-be70-85fc-4b819fa7d47c@xen0n.name> (raw)
In-Reply-To: <CAK8P3a0tu4ZANdxY-beVb4C1hKrn2VJqpfwBemhqHkr6760b7A@mail.gmail.com>
On 6/1/22 04:40, Arnd Bergmann wrote:
> lib/test_printf.c:215: warning: "PTR" redefined
> 215 | #define PTR ((void *)0xffff0123456789abUL)
> |
> In file included from /git/arm-soc/arch/loongarch/include/asm/vdso/vdso.h:9,
> from
> /git/arm-soc/arch/loongarch/include/asm/vdso/gettimeofday.h:13,
> from /git/arm-soc/include/vdso/datapage.h:137,
> from /git/arm-soc/arch/loongarch/include/asm/vdso.h:11,
> from /git/arm-soc/arch/loongarch/include/asm/elf.h:13,
> from /git/arm-soc/include/linux/elf.h:6,
> from /git/arm-soc/include/linux/module.h:19,
> from /git/arm-soc/lib/test_printf.c:10:
> /git/arm-soc/arch/loongarch/include/asm/asm.h:182: note: this is the
> location of the previous definition
> 182 | #define PTR .dword
> |
>
> Not sure what the best fix is for this, maybe the contents of asm/asm.h could
> just be hidden in an "#idef __ASSEMBLER__" check. This can be a follow-up
> patch when the branch is merged.
Ah, the dreaded PTR... This has plagued Loongson users since antiquity
(i.e. the MIPS era).
It must have been the case that the arch/loongarch was based on an
earlier version of arch/mips, that didn't have the commit fa62f39dc7e25
("MIPS: Fix build error due to PTR used in more places"). So the fix
would be simple: just rename the PTR to something else. MIPS changed
that to PTR_WD and maybe we could re-use that name.
But I agree that wrapping the whole asm/asm.h with an #ifdef
__ASSEMBLY__ is very reasonable regardless. Maybe both could be done.
next prev parent reply other threads:[~2022-06-01 8:10 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAK8P3a2_52JPnBWNvTTkFVwLxPAa7=NaQ4whwC1UeH_NYHeUKQ@mail.gmail.com>
2022-05-29 11:24 ` Arnd Bergmann
2022-05-29 13:10 ` WANG Xuerui
2022-05-30 8:20 ` Arnd Bergmann
2022-05-30 13:01 ` Huacai Chen
2022-05-30 15:00 ` WANG Xuerui
2022-05-30 15:55 ` Arnd Bergmann
2022-05-31 7:50 ` Huacai Chen
2022-05-31 8:09 ` Arnd Bergmann
2022-05-31 8:17 ` Huacai Chen
2022-05-31 11:15 ` Arnd Bergmann
2022-05-31 16:01 ` Huacai Chen
2022-05-31 20:07 ` Arnd Bergmann
2022-05-31 20:40 ` Arnd Bergmann
2022-06-01 0:41 ` WANG Xuerui [this message]
2022-06-01 1:13 ` WANG Xuerui
2022-06-01 5:52 ` WANG Xuerui
2022-06-01 7:41 ` Arnd Bergmann
2022-06-01 16:01 ` Ard Biesheuvel
2022-06-01 16:44 ` WANG Xuerui
2022-06-02 10:02 ` Huacai Chen
2022-05-29 13:21 ` Marc Zyngier
2022-05-30 6:28 ` Huacai Chen
2022-05-30 8:36 ` Arnd Bergmann
2022-05-30 8:23 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1dbaed5d-fb83-be70-85fc-4b819fa7d47c@xen0n.name \
--to=kernel@xen0n.name \
--cc=ardb@kernel.org \
--cc=arnd@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lvjianmin@loongson.cn \
--cc=masahiroy@kernel.org \
--cc=maz@kernel.org \
--cc=musl@lists.openwall.com \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).