From: Arnd Bergmann <arnd@kernel.org>
To: Huacai Chen <chenhuacai@kernel.org>
Cc: musl@lists.openwall.com, WANG Xuerui <kernel@xen0n.name>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-arch <linux-arch@vger.kernel.org>,
GNU C Library <libc-alpha@sourceware.org>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Peter Zijlstra <peterz@infradead.org>,
Marc Zyngier <maz@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Jiaxun Yang <jiaxun.yang@flygoat.com>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
Jianmin Lv <lvjianmin@loongson.cn>,
linux-pci <linux-pci@vger.kernel.org>,
Ard Biesheuvel <ardb@kernel.org>,
Huacai Chen <chenhuacai@loongson.cn>
Subject: Re: [musl] Re: [GIT PULL] asm-generic changes for 5.19
Date: Tue, 31 May 2022 13:15:01 +0200 [thread overview]
Message-ID: <CAK8P3a0c_tbHov_b6cz-_Tj6VD3OWLwpGJf_2rj-nitipSKdYQ@mail.gmail.com> (raw)
In-Reply-To: <CAAhV-H6wfmdcV=a4L43dcabsvO+JbOebCX3_6PV+p85NjA9qhQ@mail.gmail.com>
On Tue, May 31, 2022 at 10:17 AM Huacai Chen <chenhuacai@kernel.org> wrote:
> On Tue, May 31, 2022 at 4:09 PM Arnd Bergmann <arnd@kernel.org> wrote:
> >
> > On Tue, May 31, 2022 at 9:50 AM Huacai Chen <chenhuacai@kernel.org> wrote:
> > > On Mon, May 30, 2022 at 11:56 PM Arnd Bergmann <arnd@kernel.org> wrote:
> > > > On Mon, May 30, 2022 at 5:00 PM WANG Xuerui <kernel@xen0n.name> wrote:
> > > > > Now I see
> > > > > the loongarch-next HEAD is already rebased on top of what I believe to
> > > > > be the current main branch, however I vaguely remember that it's not
> > > > > good to base one's patches on top of "some random commit", so I wonder
> > > > > whether the current branch state is appropriate for a PR?
> > > >
> > > > You are correct, a pull request should always be based on an -rc, orat least
> > > > have the minimum set of dependencies. The branch was previously
> > > > based on top of the spinlock implementation, which is still the best
> > > > place to start here.
> > > I have a difficult problem to select the base. Take swiotlb_init() as
> > > an example: If I select 5.18-rc1, I should use swiotlb_init(1); if I
> > > select Linus' latest tree, I should use swiotlb_init(true,
> > > SWIOTLB_VERBOSE). However, if I select 5.18-rc1, linux-next will have
> > > a build error because the code there expect swiotlb_init(true,
> > > SWIOTLB_VERBOSE).
> >
> > Ok, I see. This is the kind of thing we normally prevent by having everything
> > in linux-next for a few weeks before the merge window. How many issues
> > like this are you aware of? If it's just the swiotlb, you could try merging
> > the swiotlb branch that is in mainline now on top of the spinlock branch,
> > and still get a minimum set of dependencies. If there are many more,
> > then basing on top of the current mainline is probably less intrusive after
> > all.
> I have 3 issues:
> 1, swiotlb_init(1) --> swiotlb_init(true, SWIOTLB_VERBOSE);
> 2, the prototype of handle_kernel_image() should be changed from 5
> parameters to 6 parameters;
> 3, the return value type of huge_ptep_get_and_clear() should be
> changed from void to pte_t (and the function implementation should be
> also changed).
Ok, I see. Let's stay with the base on top of a mainline snapshot then.
Arnd
next prev parent reply other threads:[~2022-05-31 11:15 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAK8P3a2_52JPnBWNvTTkFVwLxPAa7=NaQ4whwC1UeH_NYHeUKQ@mail.gmail.com>
2022-05-29 11:24 ` Arnd Bergmann
2022-05-29 13:10 ` WANG Xuerui
2022-05-30 8:20 ` Arnd Bergmann
2022-05-30 13:01 ` Huacai Chen
2022-05-30 15:00 ` WANG Xuerui
2022-05-30 15:55 ` Arnd Bergmann
2022-05-31 7:50 ` Huacai Chen
2022-05-31 8:09 ` Arnd Bergmann
2022-05-31 8:17 ` Huacai Chen
2022-05-31 11:15 ` Arnd Bergmann [this message]
2022-05-31 16:01 ` Huacai Chen
2022-05-31 20:07 ` Arnd Bergmann
2022-05-31 20:40 ` Arnd Bergmann
2022-06-01 0:41 ` WANG Xuerui
2022-06-01 1:13 ` WANG Xuerui
2022-06-01 5:52 ` WANG Xuerui
2022-06-01 7:41 ` Arnd Bergmann
2022-06-01 16:01 ` Ard Biesheuvel
2022-06-01 16:44 ` WANG Xuerui
2022-06-02 10:02 ` Huacai Chen
2022-05-29 13:21 ` Marc Zyngier
2022-05-30 6:28 ` Huacai Chen
2022-05-30 8:36 ` Arnd Bergmann
2022-05-30 8:23 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAK8P3a0c_tbHov_b6cz-_Tj6VD3OWLwpGJf_2rj-nitipSKdYQ@mail.gmail.com \
--to=arnd@kernel.org \
--cc=ardb@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=jiaxun.yang@flygoat.com \
--cc=kernel@xen0n.name \
--cc=libc-alpha@sourceware.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lvjianmin@loongson.cn \
--cc=masahiroy@kernel.org \
--cc=maz@kernel.org \
--cc=musl@lists.openwall.com \
--cc=peterz@infradead.org \
--cc=torvalds@linux-foundation.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).