* [PATCH] add eventfd syscall wrapper and helper abstractions as in glibc
@ 2011-05-04 19:59 Serge Ziryukin
2011-05-05 4:15 ` [PATCH] add eventfd syscall wrapper and helper Rich Felker
0 siblings, 1 reply; 5+ messages in thread
From: Serge Ziryukin @ 2011-05-04 19:59 UTC (permalink / raw)
To: musl; +Cc: Serge Ziryukin
abstractions are:
typedef uint64_t eventfd_t;
int eventfd_read(int fd, eventfd_t *value);
int eventfd_write(int fd, eventfd_t value);
these are trying to hide the details of reading and writing
on an eventfd descriptor.
Signed-off-by: Serge Ziryukin <ftrvxmtrx@gmail.com>
---
include/sys/eventfd.h | 25 +++++++++++++++++++++++++
src/linux/eventfd.c | 7 +++++++
src/linux/eventfd_read.c | 7 +++++++
src/linux/eventfd_write.c | 7 +++++++
4 files changed, 46 insertions(+), 0 deletions(-)
create mode 100644 include/sys/eventfd.h
create mode 100644 src/linux/eventfd.c
create mode 100644 src/linux/eventfd_read.c
create mode 100644 src/linux/eventfd_write.c
diff --git a/include/sys/eventfd.h b/include/sys/eventfd.h
new file mode 100644
index 0000000..13bc9c4
--- /dev/null
+++ b/include/sys/eventfd.h
@@ -0,0 +1,25 @@
+#ifndef _SYS_EVENTFD_H
+#define _SYS_EVENTFD_H
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+#include <stdint.h>
+
+typedef uint64_t eventfd_t;
+
+#define EFD_SEMAPHORE 1
+#define EFD_CLOEXEC 02000000
+#define EFD_NONBLOCK 04000
+
+int eventfd(unsigned int, int);
+int eventfd_read(int, eventfd_t *);
+int eventfd_write(int, eventfd_t);
+
+
+#ifdef __cplusplus
+}
+#endif
+
+#endif /* sys/eventfd.h */
diff --git a/src/linux/eventfd.c b/src/linux/eventfd.c
new file mode 100644
index 0000000..2ddfc68
--- /dev/null
+++ b/src/linux/eventfd.c
@@ -0,0 +1,7 @@
+#include <sys/eventfd.h>
+#include "syscall.h"
+
+int eventfd(unsigned int count, int flags)
+{
+ return syscall(SYS_eventfd, count, flags);
+}
diff --git a/src/linux/eventfd_read.c b/src/linux/eventfd_read.c
new file mode 100644
index 0000000..969e661
--- /dev/null
+++ b/src/linux/eventfd_read.c
@@ -0,0 +1,7 @@
+#include <sys/eventfd.h>
+#include <unistd.h>
+
+int eventfd_read(int fd, eventfd_t *value)
+{
+ return (sizeof(*value) == read(fd, value, sizeof(*value))) ? 0 : -1;
+}
diff --git a/src/linux/eventfd_write.c b/src/linux/eventfd_write.c
new file mode 100644
index 0000000..734fa36
--- /dev/null
+++ b/src/linux/eventfd_write.c
@@ -0,0 +1,7 @@
+#include <sys/eventfd.h>
+#include <unistd.h>
+
+int eventfd_write(int fd, eventfd_t value)
+{
+ return (sizeof(value) == write(fd, &value, sizeof(value))) ? 0 : -1;
+}
--
1.7.5
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] add eventfd syscall wrapper and helper
2011-05-04 19:59 [PATCH] add eventfd syscall wrapper and helper abstractions as in glibc Serge Ziryukin
@ 2011-05-05 4:15 ` Rich Felker
2011-05-05 5:27 ` Serge Ziryukin
0 siblings, 1 reply; 5+ messages in thread
From: Rich Felker @ 2011-05-05 4:15 UTC (permalink / raw)
To: musl
On Wed, May 04, 2011 at 10:59:45PM +0300, Serge Ziryukin wrote:
> abstractions are:
>
> typedef uint64_t eventfd_t;
> int eventfd_read(int fd, eventfd_t *value);
> int eventfd_write(int fd, eventfd_t value);
>
> these are trying to hide the details of reading and writing
> on an eventfd descriptor.
Seems silly, but if that's the usual API I have no objections. It's
small anyway.
> +int eventfd(unsigned int count, int flags)
> +{
> + return syscall(SYS_eventfd, count, flags);
> +}
Shouldn't this be flags ? SYS_eventfd2 : SYS_eventfd...? The old
SYS_eventfd supposedly does not support flags.
Rich
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] add eventfd syscall wrapper and helper
2011-05-05 4:15 ` [PATCH] add eventfd syscall wrapper and helper Rich Felker
@ 2011-05-05 5:27 ` Serge Ziryukin
2011-05-05 5:30 ` [PATCH] add eventfd syscall wrapper and helper abstractions as in glibc Serge Ziryukin
0 siblings, 1 reply; 5+ messages in thread
From: Serge Ziryukin @ 2011-05-05 5:27 UTC (permalink / raw)
To: musl
On Thu, May 5, 2011 at 7:15 AM, Rich Felker <dalias@aerifal.cx> wrote:
> On Wed, May 04, 2011 at 10:59:45PM +0300, Serge Ziryukin wrote:
>> abstractions are:
>>
>> typedef uint64_t eventfd_t;
>> int eventfd_read(int fd, eventfd_t *value);
>> int eventfd_write(int fd, eventfd_t value);
>>
>> these are trying to hide the details of reading and writing
>> on an eventfd descriptor.
>
> Seems silly, but if that's the usual API I have no objections. It's
> small anyway.
>
>> +int eventfd(unsigned int count, int flags)
>> +{
>> + return syscall(SYS_eventfd, count, flags);
>> +}
>
> Shouldn't this be flags ? SYS_eventfd2 : SYS_eventfd...? The old
> SYS_eventfd supposedly does not support flags.
>
Oh, sorry. My mistake.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] add eventfd syscall wrapper and helper abstractions as in glibc
2011-05-05 5:27 ` Serge Ziryukin
@ 2011-05-05 5:30 ` Serge Ziryukin
2011-05-08 4:26 ` Rich Felker
0 siblings, 1 reply; 5+ messages in thread
From: Serge Ziryukin @ 2011-05-05 5:30 UTC (permalink / raw)
To: musl; +Cc: Serge Ziryukin
abstractions are:
typedef uint64_t eventfd_t;
int eventfd_read(int fd, eventfd_t *value);
int eventfd_write(int fd, eventfd_t value);
these are trying to hide the details of reading and writing
on an eventfd descriptor.
Signed-off-by: Serge Ziryukin <ftrvxmtrx@gmail.com>
---
include/sys/eventfd.h | 25 +++++++++++++++++++++++++
src/linux/eventfd.c | 7 +++++++
src/linux/eventfd_read.c | 7 +++++++
src/linux/eventfd_write.c | 7 +++++++
4 files changed, 46 insertions(+), 0 deletions(-)
create mode 100644 include/sys/eventfd.h
create mode 100644 src/linux/eventfd.c
create mode 100644 src/linux/eventfd_read.c
create mode 100644 src/linux/eventfd_write.c
diff --git a/include/sys/eventfd.h b/include/sys/eventfd.h
new file mode 100644
index 0000000..13bc9c4
--- /dev/null
+++ b/include/sys/eventfd.h
@@ -0,0 +1,25 @@
+#ifndef _SYS_EVENTFD_H
+#define _SYS_EVENTFD_H
+
+#ifdef __cplusplus
+extern "C" {
+#endif
+
+#include <stdint.h>
+
+typedef uint64_t eventfd_t;
+
+#define EFD_SEMAPHORE 1
+#define EFD_CLOEXEC 02000000
+#define EFD_NONBLOCK 04000
+
+int eventfd(unsigned int, int);
+int eventfd_read(int, eventfd_t *);
+int eventfd_write(int, eventfd_t);
+
+
+#ifdef __cplusplus
+}
+#endif
+
+#endif /* sys/eventfd.h */
diff --git a/src/linux/eventfd.c b/src/linux/eventfd.c
new file mode 100644
index 0000000..2ddfc68
--- /dev/null
+++ b/src/linux/eventfd.c
@@ -0,0 +1,7 @@
+#include <sys/eventfd.h>
+#include "syscall.h"
+
+int eventfd(unsigned int count, int flags)
+{
+ return syscall(SYS_eventfd2, count, flags);
+}
diff --git a/src/linux/eventfd_read.c b/src/linux/eventfd_read.c
new file mode 100644
index 0000000..969e661
--- /dev/null
+++ b/src/linux/eventfd_read.c
@@ -0,0 +1,7 @@
+#include <sys/eventfd.h>
+#include <unistd.h>
+
+int eventfd_read(int fd, eventfd_t *value)
+{
+ return (sizeof(*value) == read(fd, value, sizeof(*value))) ? 0 : -1;
+}
diff --git a/src/linux/eventfd_write.c b/src/linux/eventfd_write.c
new file mode 100644
index 0000000..734fa36
--- /dev/null
+++ b/src/linux/eventfd_write.c
@@ -0,0 +1,7 @@
+#include <sys/eventfd.h>
+#include <unistd.h>
+
+int eventfd_write(int fd, eventfd_t value)
+{
+ return (sizeof(value) == write(fd, &value, sizeof(value))) ? 0 : -1;
+}
--
1.7.5
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] add eventfd syscall wrapper and helper abstractions as in glibc
2011-05-05 5:30 ` [PATCH] add eventfd syscall wrapper and helper abstractions as in glibc Serge Ziryukin
@ 2011-05-08 4:26 ` Rich Felker
0 siblings, 0 replies; 5+ messages in thread
From: Rich Felker @ 2011-05-08 4:26 UTC (permalink / raw)
To: musl
On Thu, May 05, 2011 at 08:30:18AM +0300, Serge Ziryukin wrote:
> abstractions are:
>
> typedef uint64_t eventfd_t;
> int eventfd_read(int fd, eventfd_t *value);
> int eventfd_write(int fd, eventfd_t value);
>
> these are trying to hide the details of reading and writing
> on an eventfd descriptor.
Committed with some minor changes for old-kernel compatibility (only
using SYS_eventfd2 if flags!=0)
Rich
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-05-08 4:26 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-05-04 19:59 [PATCH] add eventfd syscall wrapper and helper abstractions as in glibc Serge Ziryukin
2011-05-05 4:15 ` [PATCH] add eventfd syscall wrapper and helper Rich Felker
2011-05-05 5:27 ` Serge Ziryukin
2011-05-05 5:30 ` [PATCH] add eventfd syscall wrapper and helper abstractions as in glibc Serge Ziryukin
2011-05-08 4:26 ` Rich Felker
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).