From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: cluts review
Date: Thu, 14 Jul 2011 14:56:01 -0400 [thread overview]
Message-ID: <20110714185601.GM16618@brightrain.aerifal.cx> (raw)
In-Reply-To: <4E1DCDE5.1040008@gmail.com>
On Wed, Jul 13, 2011 at 06:55:01PM +0200, Luka Marčetić wrote:
> >I got lots of errors from "numeric" - I didn't bother recording most.
> >The above are just a few of them.
>
> In my opinion, the errors are warranted. But I asked Rich for review
I'm a bit confused by this one:
strtoumax("0xX", &endptr) should return 0, errno=0(Invalid error number)
instead, it returns 0, errno=EINVAL
Why do you expect it to return with errno=0? Since the subject
sequence does not have a correct form, I believe the implementation
may (and should, from a quality of implementation standpoint) set
errno to EINVAL. Of course a portable application will need to examine
endptr instead of errno to check this case.
The remaining errors all seem correct. It's expected that glibc fails
lots of these tests. See:
http://sourceware.org/bugzilla/show_bug.cgi?id=12701
Rich
next prev parent reply other threads:[~2011-07-14 18:56 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-13 11:07 Solar Designer
2011-07-13 12:02 ` Luka Marčetić
2011-07-13 12:21 ` Solar Designer
2011-07-13 12:57 ` Luka Marčetić
2011-07-13 13:42 ` Rich Felker
2011-07-13 14:21 ` Solar Designer
2011-07-13 13:54 ` Solar Designer
2011-07-13 14:00 ` Rich Felker
2011-07-13 14:31 ` Solar Designer
2011-07-13 14:03 ` Rich Felker
2011-07-13 14:37 ` Solar Designer
2011-07-13 16:03 ` Solar Designer
2011-07-13 16:55 ` Luka Marčetić
2011-07-13 17:05 ` Solar Designer
2011-07-13 17:25 ` Luka Marčetić
2011-07-13 17:52 ` Solar Designer
2011-07-13 19:29 ` Luka Marčetić
2011-07-13 19:55 ` Rich Felker
2011-07-13 20:39 ` Solar Designer
2011-07-13 21:44 ` Solar Designer
2011-07-13 19:52 ` Rich Felker
2011-07-13 20:03 ` Rich Felker
2011-07-14 18:56 ` Rich Felker [this message]
2011-07-13 13:38 ` Rich Felker
2011-07-13 14:12 ` Solar Designer
2011-07-13 14:26 ` Rich Felker
2011-07-13 14:46 ` Solar Designer
2011-07-13 16:25 ` Luka Marčetić
2011-07-13 17:03 ` Solar Designer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110714185601.GM16618@brightrain.aerifal.cx \
--to=dalias@aerifal.cx \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).