SIG_* in signal.h

SIG_* in signal.h

[Szabolcs Nagy]

i just tried to compile pcc using musl
and it failed because SIG_IGN was undefined

it seem SIG_ING, SIG_ERR, SIG_DFL are ifdefed
with various featuretest macros in signal.h
eventhough they are ansic

Re: SIG_* in signal.h

[Isaac Dunham]

On Thu, 17 May 2012 00:12:27 +0200
Szabolcs Nagy <nsz@port70.net> wrote:

> i just tried to compile pcc using musl
> and it failed because SIG_IGN was undefined
> 
> it seem SIG_ING, SIG_ERR, SIG_DFL are ifdefed
> with various featuretest macros in signal.h
> eventhough they are ansic
> 
Not what stopped it for me: 

/opt/musl/bin/pcc -std=c99 -ffreestanding -nostdinc
-D_XOPEN_SOURCE=700 -I./src/internal -I./include -I./arch/i386  -Os
-pipe -O2 -c -o src/complex/__cexp.o src/complex/__cexp.c
src/complex/__cexp.c, line 72: operands of CAST have incompatible types
src/complex/__cexp.c, line 73: operands of CAST have incompatible types
make: *** [src/complex/__cexp.o] Error 1

Re: SIG_* in signal.h

[Szabolcs Nagy]

* Isaac Dunham <idunham@lavabit.com> [2012-05-16 16:05:12 -0700]:

> On Thu, 17 May 2012 00:12:27 +0200
> Szabolcs Nagy <nsz@port70.net> wrote:
> 
> > i just tried to compile pcc using musl
> > and it failed because SIG_IGN was undefined
> > 
> > it seem SIG_ING, SIG_ERR, SIG_DFL are ifdefed
> > with various featuretest macros in signal.h
> > eventhough they are ansic
> > 
> Not what stopped it for me: 
> 
you are compiling musl with pcc and not pcc with musl :)

> /opt/musl/bin/pcc -std=c99 -ffreestanding -nostdinc
> -D_XOPEN_SOURCE=700 -I./src/internal -I./include -I./arch/i386  -Os
> -pipe -O2 -c -o src/complex/__cexp.o src/complex/__cexp.c
> src/complex/__cexp.c, line 72: operands of CAST have incompatible types
> src/complex/__cexp.c, line 73: operands of CAST have incompatible types
> make: *** [src/complex/__cexp.o] Error 1
i could compile recent musl with recent pcc without errors

Re: SIG_* in signal.h

[Szabolcs Nagy]

* Szabolcs Nagy <nsz@port70.net> [2012-05-17 01:11:20 +0200]:
> * Isaac Dunham <idunham@lavabit.com> [2012-05-16 16:05:12 -0700]:
> > /opt/musl/bin/pcc -std=c99 -ffreestanding -nostdinc
> > -D_XOPEN_SOURCE=700 -I./src/internal -I./include -I./arch/i386  -Os
> > -pipe -O2 -c -o src/complex/__cexp.o src/complex/__cexp.c
> > src/complex/__cexp.c, line 72: operands of CAST have incompatible types
> > src/complex/__cexp.c, line 73: operands of CAST have incompatible types
> > make: *** [src/complex/__cexp.o] Error 1
> i could compile recent musl with recent pcc without errors

sorry my musl was out of date and i had local modifications as well
so yes the complex code does not build

and in src/network/h_errno.c the undef is broken

otherwise it seems to work here

Re: SIG_* in signal.h

[Isaac Dunham]

On Thu, 17 May 2012 01:11:20 +0200
Szabolcs Nagy <nsz@port70.net> wrote:

> * Isaac Dunham <idunham@lavabit.com> [2012-05-16 16:05:12 -0700]:
> 
> > On Thu, 17 May 2012 00:12:27 +0200
> > Szabolcs Nagy <nsz@port70.net> wrote:
> > 
> > > i just tried to compile pcc using musl
> > > and it failed because SIG_IGN was undefined
> > > 
> > > it seem SIG_ING, SIG_ERR, SIG_DFL are ifdefed
> > > with various featuretest macros in signal.h
> > > eventhough they are ansic
> > > 
> > Not what stopped it for me: 
> > 
> you are compiling musl with pcc and not pcc with musl :)

Mixed up on the wires.
> > /opt/musl/bin/pcc -std=c99 -ffreestanding -nostdinc
> > -D_XOPEN_SOURCE=700 ....
Everything in /opt/musl is built against a fairly current musl...
pcc was built against my 'fixes' (really ought to be "hacks" ;) ) 
branch, which is current enough that this morning, 
git pull origin master 
said it was up-to-date.
pcc & pcc-libs are version 20120516.
I used -D_BSD_SOURCE and maybe also -D_GNU_SOURCE, though.

Re: SIG_* in signal.h

[Rich Felker]

On Thu, May 17, 2012 at 12:12:27AM +0200, Szabolcs Nagy wrote:
> i just tried to compile pcc using musl
> and it failed because SIG_IGN was undefined
> 
> it seem SIG_ING, SIG_ERR, SIG_DFL are ifdefed
> with various featuretest macros in signal.h
> eventhough they are ansic

Are you sure? I don't see that problem in my version and as far as I
know I fixed that bug about a year ago...

Rich

Re: SIG_* in signal.h

[Isaac Dunham]

On Wed, 16 May 2012 20:14:16 -0400
Rich Felker <dalias@aerifal.cx> wrote:

> On Thu, May 17, 2012 at 12:12:27AM +0200, Szabolcs Nagy wrote:
> > i just tried to compile pcc using musl
> > and it failed because SIG_IGN was undefined
> > 
> > it seem SIG_ING, SIG_ERR, SIG_DFL are ifdefed
> > with various featuretest macros in signal.h
> > eventhough they are ansic
> 
> Are you sure? I don't see that problem in my version and as far as I
> know I fixed that bug about a year ago...
Don't see it here, either. OTOH, it's not easy to see that it isn't the
case.
Line 205 marks the end of the #ifdef _EVERYBODY_AND_HIS_DOG_SOURCE
macros, which start at lines 8 & 9.  I'd like to see an editor where
you can tell that without reading every line in between...(not to start
a war over editors, mind you!)
This is where I see a reason for stuff like:
#endif /* XOPEN/GNU/POSIX */
A comment after every endif (like glibc does) is rather absurd, though.

And it seems to me that usually the non-macro-protected code goes on
top, making it clearer what is ANSI...

Not to say that it's wrong, just that it could be clearer.

Isaac Dunham

Re: SIG_* in signal.h

[Szabolcs Nagy]

* Rich Felker <dalias@aerifal.cx> [2012-05-16 20:14:16 -0400]:
> On Thu, May 17, 2012 at 12:12:27AM +0200, Szabolcs Nagy wrote:
> > it seem SIG_ING, SIG_ERR, SIG_DFL are ifdefed
> > with various featuretest macros in signal.h
> > eventhough they are ansic
> 
> Are you sure? I don't see that problem in my version and as far as I
> know I fixed that bug about a year ago...
> 
sorry it was looking at the wrong musl