* optional compat?
@ 2013-12-27 23:11 Justin Cormack
2013-12-28 1:32 ` Rich Felker
0 siblings, 1 reply; 5+ messages in thread
From: Justin Cormack @ 2013-12-27 23:11 UTC (permalink / raw)
To: musl
The include files sys/errno.h and sys/signal.h, to work around broken
code are a bit inconsistent, one has a #warning and the other doesnt.
I would actually rather that they were only installed if requested, as
(in an unusual situation) they are actually causing me issues. It
would seem nicer to have a make installbroken as well...
Justin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: optional compat?
2013-12-27 23:11 optional compat? Justin Cormack
@ 2013-12-28 1:32 ` Rich Felker
2013-12-30 18:12 ` Justin Cormack
2013-12-31 9:23 ` Justin Cormack
0 siblings, 2 replies; 5+ messages in thread
From: Rich Felker @ 2013-12-28 1:32 UTC (permalink / raw)
To: musl
On Fri, Dec 27, 2013 at 11:11:45PM +0000, Justin Cormack wrote:
> The include files sys/errno.h and sys/signal.h, to work around broken
> code are a bit inconsistent, one has a #warning and the other doesnt.
> I would actually rather that they were only installed if requested, as
> (in an unusual situation) they are actually causing me issues. It
> would seem nicer to have a make installbroken as well...
Could you elaborate on how they're causing a problem? It's preferred
to avoid creating multiple configuration variants which would then
need to have their own application compatibility studies...
Rich
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: optional compat?
2013-12-28 1:32 ` Rich Felker
@ 2013-12-30 18:12 ` Justin Cormack
2013-12-31 9:23 ` Justin Cormack
1 sibling, 0 replies; 5+ messages in thread
From: Justin Cormack @ 2013-12-30 18:12 UTC (permalink / raw)
To: musl
On Sat, Dec 28, 2013 at 1:32 AM, Rich Felker <dalias@aerifal.cx> wrote:
> On Fri, Dec 27, 2013 at 11:11:45PM +0000, Justin Cormack wrote:
>> The include files sys/errno.h and sys/signal.h, to work around broken
>> code are a bit inconsistent, one has a #warning and the other doesnt.
>> I would actually rather that they were only installed if requested, as
>> (in an unusual situation) they are actually causing me issues. It
>> would seem nicer to have a make installbroken as well...
>
> Could you elaborate on how they're causing a problem? It's preferred
> to avoid creating multiple configuration variants which would then
> need to have their own application compatibility studies...
I think best to ignore, will fix the build...
Justin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: optional compat?
2013-12-28 1:32 ` Rich Felker
2013-12-30 18:12 ` Justin Cormack
@ 2013-12-31 9:23 ` Justin Cormack
2013-12-31 15:22 ` Rich Felker
1 sibling, 1 reply; 5+ messages in thread
From: Justin Cormack @ 2013-12-31 9:23 UTC (permalink / raw)
To: musl
On Sat, Dec 28, 2013 at 1:32 AM, Rich Felker <dalias@aerifal.cx> wrote:
> On Fri, Dec 27, 2013 at 11:11:45PM +0000, Justin Cormack wrote:
>> The include files sys/errno.h and sys/signal.h, to work around broken
>> code are a bit inconsistent, one has a #warning and the other doesnt.
>> I would actually rather that they were only installed if requested, as
>> (in an unusual situation) they are actually causing me issues. It
>> would seem nicer to have a make installbroken as well...
>
> Could you elaborate on how they're causing a problem? It's preferred
> to avoid creating multiple configuration variants which would then
> need to have their own application compatibility studies...
I worked out what the issue was - the #warning breaks the make depend
step as it can't parse the output. So removing the warning fixes it,
and so does removing the file as the dependency seems to be bogus
anyway. Will still try to fix it upstream, but coming round to the
view that if we have these files they shouldn't have #warnings in.
Justin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: optional compat?
2013-12-31 9:23 ` Justin Cormack
@ 2013-12-31 15:22 ` Rich Felker
0 siblings, 0 replies; 5+ messages in thread
From: Rich Felker @ 2013-12-31 15:22 UTC (permalink / raw)
To: musl
On Tue, Dec 31, 2013 at 09:23:37AM +0000, Justin Cormack wrote:
> On Sat, Dec 28, 2013 at 1:32 AM, Rich Felker <dalias@aerifal.cx> wrote:
> > On Fri, Dec 27, 2013 at 11:11:45PM +0000, Justin Cormack wrote:
> >> The include files sys/errno.h and sys/signal.h, to work around broken
> >> code are a bit inconsistent, one has a #warning and the other doesnt.
> >> I would actually rather that they were only installed if requested, as
> >> (in an unusual situation) they are actually causing me issues. It
> >> would seem nicer to have a make installbroken as well...
> >
> > Could you elaborate on how they're causing a problem? It's preferred
> > to avoid creating multiple configuration variants which would then
> > need to have their own application compatibility studies...
>
> I worked out what the issue was - the #warning breaks the make depend
> step as it can't parse the output. So removing the warning fixes it,
> and so does removing the file as the dependency seems to be bogus
> anyway. Will still try to fix it upstream, but coming round to the
> view that if we have these files they shouldn't have #warnings in.
Is this script mixing stderr with stdout for the purpose of parsing?
Warnings should not affect parsing, and in fact other warnings could
potentially happen, e.g. with custom CFLAGS or newer compiler versions
that add new default warnings...
Rich
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-12-31 15:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-12-27 23:11 optional compat? Justin Cormack
2013-12-28 1:32 ` Rich Felker
2013-12-30 18:12 ` Justin Cormack
2013-12-31 9:23 ` Justin Cormack
2013-12-31 15:22 ` Rich Felker
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).