mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Subject: Re: getrandom syscall
Date: Wed, 28 Jan 2015 13:26:41 +0100	[thread overview]
Message-ID: <20150128122640.GF32318@port70.net> (raw)
In-Reply-To: <CAPLrYEQo7Q64Z94UkZADu_pjEEs88fW6_BH9=vpC=z4kWOWjMQ@mail.gmail.com>

* Daniel Cegie??ka <daniel.cegielka@gmail.com> [2015-01-28 10:10:53 +0100]:
> 2015-01-28 10:02 GMT+01:00 Szabolcs Nagy <nsz@port70.net>:
> >
> > #ifdef SYS_getrandom
...
> > #endif
> >
> > eg sh does not have the syscall (linux is not consistent with
> > syscalls for whatever reason)
> 
> SYS_getrandom is defined on musl, so #ifdef SYS_getrandom is not a
> good solution:
> 
> http://git.musl-libc.org/cgit/musl/tree/arch/x86_64/bits/syscall.h#n657
> 
> It's better to return an error.

no

you should return runtime error if the syscall fails
(eg you are on old kernel that does not support the syscall)

but you cannot use this code if SYS_getrandom is not
defined (eg. sh arch) because it will be a musl
compile time failure (sadly linux does not allocate
syscall numbers on all archs so musl cannot define
all SYS_ macros consistently on all archs either)


  reply	other threads:[~2015-01-28 12:26 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-27 22:12 Daniel Cegiełka
2015-01-28  9:02 ` Szabolcs Nagy
2015-01-28  9:10   ` Daniel Cegiełka
2015-01-28 12:26     ` Szabolcs Nagy [this message]
2015-01-28 12:42       ` Daniel Cegiełka
2015-01-28 14:49         ` Rich Felker
2015-01-28 14:54 ` Rich Felker
2015-01-28 15:41   ` Szabolcs Nagy
2015-01-28 15:50     ` Daniel Cegiełka
2015-01-28 16:03       ` Szabolcs Nagy
2015-01-28 16:12         ` Daniel Cegiełka
2015-01-28 16:21           ` Rich Felker
2015-01-28 17:02             ` Daniel Cegiełka
2015-01-28 17:09               ` Daniel Cegiełka
2015-01-28 17:43                 ` Brent Cook
2015-01-28 18:12                   ` Daniel Cegiełka
2015-01-28 19:17                   ` Rich Felker
2015-01-28 19:33                     ` Daniel Cegiełka
2015-01-28 20:20                     ` Brent Cook
2015-01-28 22:02                       ` Rich Felker
2015-01-28 22:59                         ` Josiah Worcester
2015-02-09 20:37                         ` Andy Lutomirski
2015-01-28 16:25         ` Daniel Cegiełka
2015-01-28 16:01     ` Daniel Cegiełka
2015-01-28 15:41   ` Daniel Cegiełka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150128122640.GF32318@port70.net \
    --to=nsz@port70.net \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).