From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH] Fix TLS layout of TLS variant I when there is a gap above TP
Date: Mon, 11 Jun 2018 15:14:10 -0400 [thread overview]
Message-ID: <20180611191410.GI1392@brightrain.aerifal.cx> (raw)
In-Reply-To: <CA+RmVGyBrpGZf807jvEKQf=deO9Dy52s+fN1segBV+=yTp30aA@mail.gmail.com>
On Mon, Jun 11, 2018 at 09:02:51PM +0200, Phillip Berndt wrote:
> 2018-06-04 9:27 GMT+02:00 Phillip Berndt <phillip.berndt@googlemail.com>:
> > 2018-06-02 1:52 GMT+02:00 Szabolcs Nagy <nsz@port70.net>:
> >> The fix required changing TP_ADJ and __pthread_self on affected
> >> targets (aarch64, arm and sh) and in the tlsdesc asm the offset to
> >> access the dtv changed too.
> >> ---
> >> passed my simple local-exec tests.
> >
> >
> > Confirmed working on real aarch64, too. Awesome work, thanks a lot!
> >
>
> Got an opportunity to test this on real 32-bit arm hardware, fixes the
> issue there for me as well.
>
> Any news on the review & merge of the patch?
Yes, I think it's fine and I've got it queued with a [much longer than
I realized! sorry!] batch of commits to push. Will look over things
and push asap after checking I didn't do anything stupid aside from
leaving them sitting so long.
Rich
prev parent reply other threads:[~2018-06-11 19:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 23:52 Szabolcs Nagy
2018-06-02 2:59 ` Rich Felker
2018-06-02 7:15 ` Szabolcs Nagy
2018-06-03 1:11 ` Rich Felker
2018-06-04 7:27 ` Phillip Berndt
2018-06-11 19:02 ` Phillip Berndt
2018-06-11 19:14 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180611191410.GI1392@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).