From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH] arm asm for vfork
Date: Tue, 17 Jul 2018 22:35:26 -0400 [thread overview]
Message-ID: <20180718023526.GO1392@brightrain.aerifal.cx> (raw)
In-Reply-To: <CAEg67GnPaf++HTRqbp8=H9-3BwNMXtX1zeiyzWTO8JoYOHhQWw@mail.gmail.com>
On Wed, Jul 18, 2018 at 12:20:00PM +1000, Patrick Oppenlander wrote:
> Hi Rich,
>
> I saw another thread where it was mentioned you may be doing a 1.20
> release some time soon.
>
> Is there any chance this could get merged in time? I've been running
> it for months without any issues now.
>
> Attached is an updated patch using svc rather than swi.
Thanks. One detail:
> diff --git a/src/process/arm/vfork.s b/src/process/arm/vfork.s
> new file mode 100644
> index 00000000..db4e7b43
> --- /dev/null
> +++ b/src/process/arm/vfork.s
> @@ -0,0 +1,12 @@
> +.syntax unified
> +.global __vfork
> +.weak vfork
> +.type __vfork,%function
> +.type vfork,%function
> +__vfork:
> +vfork:
> + mov ip, r7
> + mov r7, 190
> + svc 0
> + mov r7, ip
> + b __syscall_ret
> --
I think there needs to be a ".hidden __syscall_ret" (by de facto musl
convention, on the line before it's used) here. It *might* be ok
having the reference omit .hidden as long as the definition is hidden
at link-time (which it is), but I'm not convinced the tooling won't
complain about a branch to a destination that's not known to be
link-time constant displacement.
If you have no other changes or comments I'm happy to just --amend
that into the patch when I commit it.
Rich
next prev parent reply other threads:[~2018-07-18 2:35 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 1:36 patrick.oppenlander
2018-04-30 1:36 ` patrick.oppenlander
2018-04-30 2:09 ` Rich Felker
2018-04-30 2:32 ` Patrick Oppenlander
2018-07-18 2:20 ` Patrick Oppenlander
2018-07-18 2:35 ` Rich Felker [this message]
2018-07-18 4:14 ` Patrick Oppenlander
2018-09-06 15:02 ` Patrick Oppenlander
2018-09-06 15:19 ` Rich Felker
2018-09-07 2:05 ` Rich Felker
2018-09-07 6:29 ` Patrick Oppenlander
2018-07-18 13:44 ` Christopher Friedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180718023526.GO1392@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).