mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Subject: Re: [PATCH] fix build failure on arm because of missing clz instruction
Date: Sat, 25 Aug 2018 00:05:23 +0200	[thread overview]
Message-ID: <20180824220523.GF4418@port70.net> (raw)
In-Reply-To: <CAJ86T=UeQqfLLCa=pdc=f3ADkKsH9gZ46Jb9Kty9H-06iyjHaw@mail.gmail.com>

* Andre McCurdy <armccurdy@gmail.com> [2018-08-24 14:58:04 -0700]:
> On Fri, Aug 24, 2018 at 12:30 PM, Szabolcs Nagy <nsz@port70.net> wrote:
> > another arm patch, clz usage (in fma) was broken with -mthumb -march=armv5t.
> 
> That conditional was originally written under the assumption that musl
> doesn't support thumb1 (so -mthumb -march=armv5t is not a supported
> configuration).
> 
> Was that assumption wrong?

the asm code in musl does not support thumb1,
but you can compile everything else with thumb1
(the compiler does not pass -mthumb to the assembler
by default so all asm code will be in arm mode)

so with the changed condition the build succeeds
with -mthumb -march=armv5t, but the resulting libc
will not be competely thumb code, i think that's
an improvement.


  parent reply	other threads:[~2018-08-24 22:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-24 19:30 Szabolcs Nagy
2018-08-24 21:58 ` Andre McCurdy
2018-08-24 22:04   ` Andre McCurdy
2018-08-24 22:05   ` Szabolcs Nagy [this message]
2018-08-24 22:50     ` Andre McCurdy
2018-08-24 23:20   ` Rich Felker
2019-06-28 22:55     ` Andre McCurdy
2019-06-29  4:19       ` Rich Felker
2019-07-01 19:09         ` Andre McCurdy
2019-07-01 20:09           ` Rich Felker
2019-07-01 21:09             ` Andre McCurdy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180824220523.GF4418@port70.net \
    --to=nsz@port70.net \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).