From: Andre McCurdy <armccurdy@gmail.com>
To: musl@lists.openwall.com
Subject: Re: [PATCH] fix build failure on arm because of missing clz instruction
Date: Mon, 1 Jul 2019 12:09:26 -0700 [thread overview]
Message-ID: <CAJ86T=V-AmLTqr7S-Tz11FDUHsi5dYmqPSmQN=5m59stGTYMxw@mail.gmail.com> (raw)
In-Reply-To: <20190629041924.GI1506@brightrain.aerifal.cx>
On Fri, Jun 28, 2019 at 9:19 PM Rich Felker <dalias@libc.org> wrote:
> On Fri, Jun 28, 2019 at 03:55:56PM -0700, Andre McCurdy wrote:
> > On Fri, Aug 24, 2018 at 4:20 PM Rich Felker <dalias@libc.org> wrote:
> > > musl does not support being pure-thumb1 code, because some of the asm
> > > source files are not thumb-compatible, but I think the C code can be
> > > compiled as thumb1. -mthumb is only passed to the assembler for asm
> > > source files if __thumb2__ is defined.
> >
> > Sorry to resurrect such an old thread, but it seems this patch was
> > never applied?
> >
> > Without it, -mthumb -march=armv5t still fails to build due to clz
> > getting into C code via inline assembler.
>
> Thanks for reviving this thread. I'll commit it or something similar.
> I wonder if _ARM_ARCH>=5 && __thumb__!=1 would be a better test.
__thumb__ is either 1 (for both Thumb1 and Thumb2) or undefined (for
ARM). The above might misleadingly suggest that it's sometimes defined
with a value other than 1?
next prev parent reply other threads:[~2019-07-01 19:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-24 19:30 Szabolcs Nagy
2018-08-24 21:58 ` Andre McCurdy
2018-08-24 22:04 ` Andre McCurdy
2018-08-24 22:05 ` Szabolcs Nagy
2018-08-24 22:50 ` Andre McCurdy
2018-08-24 23:20 ` Rich Felker
2019-06-28 22:55 ` Andre McCurdy
2019-06-29 4:19 ` Rich Felker
2019-07-01 19:09 ` Andre McCurdy [this message]
2019-07-01 20:09 ` Rich Felker
2019-07-01 21:09 ` Andre McCurdy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJ86T=V-AmLTqr7S-Tz11FDUHsi5dYmqPSmQN=5m59stGTYMxw@mail.gmail.com' \
--to=armccurdy@gmail.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).