mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: riscv port for review
Date: Thu, 11 Oct 2018 11:49:27 -0400	[thread overview]
Message-ID: <20181011154927.GB5150@brightrain.aerifal.cx> (raw)
In-Reply-To: <CAGw6cBs7XPxue4w7jm5P3124Z-odh434WaJr1FZBKK-6kE=NwQ@mail.gmail.com>

On Thu, Oct 11, 2018 at 12:34:40AM -0700, Michael Forney wrote:
> On 2018-09-27, Rich Felker <dalias@libc.org> wrote:
> > Pulled from here:
> > https://github.com/riscv/riscv-musl/commit/6a4f4a9c774608add4b02f95322518bd2f5f51ee
> >
> > Attached for review.
> 
> I noticed that some fcntl.h constants are incorrect (O_DIRECTORY,
> O_NOFOLLOW, O_DIRECT, O_LARGEFILE, and O_TMPFILE). Linux doesn't seem
> to have a riscv-specific fcntl.h, so I think they just come from
> asm-generic.

If that's the case the riscv32/riscv64 bits/fcntl.h files should just
be removed and the generic one will be used.

Rich


  reply	other threads:[~2018-10-11 15:49 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-28  2:24 Rich Felker
2018-09-28  2:46 ` Rich Felker
2018-10-09 18:05   ` Rich Felker
2018-10-09 21:36     ` Michael Clark
2018-10-10  1:14       ` Khem Raj
2018-10-10  3:41         ` Michael Clark
2018-09-28  2:47 ` Rich Felker
2018-09-28  6:33   ` Michael Clark
2018-09-28  6:49     ` Michael Clark
2018-09-28 10:33     ` Szabolcs Nagy
2018-09-28 14:26       ` Rich Felker
2018-09-28 11:43 ` Szabolcs Nagy
2018-09-28 14:28   ` Rich Felker
2018-10-11  7:34 ` Michael Forney
2018-10-11 15:49   ` Rich Felker [this message]
2018-10-18 21:52   ` Michael Forney
2018-11-11  6:34     ` Michael Forney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181011154927.GB5150@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).