mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Szabolcs Nagy <nsz@port70.net>
To: musl@lists.openwall.com
Subject: Re: [PATCH] Fix many compiler warnings
Date: Sat, 10 Nov 2018 18:23:26 +0100	[thread overview]
Message-ID: <20181110172325.GD21289@port70.net> (raw)
In-Reply-To: <1636016.5PCnkOXM1K@prometheus.sedrubal.de>

* Sedrubal <dev@sedrubal.de> [2018-11-10 17:48:23 +0100]:
> I'm building musl for aarch64 with clang and get many compiler warnings
> (mostly Wbitwise-op-parentheses, Wshift-op-parentheses and Wlogical-op-parentheses).
> I tried to fix them (and I hope, I did not introduce new bugs).

suppress the warnings, you will just introduce bugs

> -	return __x>>24 | __x>>8&0xff00 | __x<<8&0xff0000 | __x<<24;
> +	return __x>>24 | __x>>(8&0xff00) | __x<<(8&0xff0000) | __x<<24;

e.g. this is wrong


  parent reply	other threads:[~2018-11-10 17:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-10 16:48 Sedrubal
2018-11-10 17:21 ` Alexander Monakov
2018-11-10 17:23 ` Szabolcs Nagy [this message]
2018-11-10 17:59 ` Markus Wichmann
2018-11-10 23:37   ` Rich Felker
2018-11-13  0:15 ` Sedrubal
2018-11-13 10:55   ` Szabolcs Nagy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181110172325.GD21289@port70.net \
    --to=nsz@port70.net \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).