From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: Re: [musl-cross-make] [PATCH] litecross: Pass --enable-deterministic-archives to binutils, not gcc
Date: Mon, 11 Feb 2019 18:30:36 -0500 [thread overview]
Message-ID: <20190211233036.GG23599@brightrain.aerifal.cx> (raw)
In-Reply-To: <CAGw6cBvYdXYc8b=VRGJg5Pr-j0avm0OzF0uEvwRj2eYu34P+8w@mail.gmail.com>
On Sun, Feb 10, 2019 at 11:27:21AM -0800, Michael Forney wrote:
> On 2018-11-05, Michael Forney <mforney@mforney.org> wrote:
> > When the gcc and binutils build trees were separated in defdbb4505,
> > --enable-deterministic-archives was accidentally left in FULL_GCC_CONFIG.
> > This had the effect of reverting commit e83fe4b8ce, breaking
> > reproducible builds (unless it was specified explicitly in config.mak).
> > ---
> > litecross/Makefile | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/litecross/Makefile b/litecross/Makefile
> > index 2f78157..4ecfa93 100644
> > --- a/litecross/Makefile
> > +++ b/litecross/Makefile
> > @@ -61,7 +61,8 @@ FULL_BINUTILS_CONFIG = \
> > --disable-werror \
> > --target=$(TARGET) --prefix= \
> > --libdir=/lib --disable-multilib \
> > - --with-sysroot=$(SYSROOT)
> > + --with-sysroot=$(SYSROOT) \
> > + --enable-deterministic-archives
> >
> > FULL_GCC_CONFIG = --enable-languages=c,c++ \
> > $(GCC_CONFIG_FOR_TARGET) \
> > @@ -74,7 +75,6 @@ FULL_GCC_CONFIG = --enable-languages=c,c++ \
> > --disable-libmudflap --disable-libsanitizer \
> > --disable-gnu-indirect-function \
> > --disable-libmpx \
> > - --enable-deterministic-archives \
> > --enable-libstdcxx-time
> >
> > FULL_MUSL_CONFIG = $(MUSL_CONFIG) \
> > --
> > 2.19.1
>
> Ping. I think this patch should be pretty uncontroversial. It is a
> simple fix for a regression introduced in defdbb4505.
>
> Would you prefer a github pull request instead?
Sorry, it was just an oversight. Applying. Thanks!
Rich
prev parent reply other threads:[~2019-02-11 23:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-06 6:36 Michael Forney
2019-02-10 19:27 ` Michael Forney
2019-02-11 23:30 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190211233036.GG23599@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).