mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: [PATCH] Fix unintended global symbols in atanl.c
Date: Wed, 3 Apr 2019 10:16:27 -0400	[thread overview]
Message-ID: <20190403141627.GP23599@brightrain.aerifal.cx> (raw)
In-Reply-To: <CACcSVPE4KhODb08y=J1Cu19uUeay2hY0iOBs7b0-auk-kAefeA@mail.gmail.com>

On Wed, Apr 03, 2019 at 05:56:08AM -0700, Dan Gohman wrote:
> Mark atanhi, atanlo, and aT in atanl.c as static, as they're not intended
> to be part of the public API.
> 
> These are already static in the LDBL_MANT_DIG == 64 code, so this patch is
> just making the LDBL_MANT_DIG == 113 code do the same thing.
> ---
>  src/math/atanl.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/src/math/atanl.c b/src/math/atanl.c
> index 79a3edb8..c3b0c926 100644
> --- a/src/math/atanl.c
> +++ b/src/math/atanl.c
> @@ -70,21 +70,21 @@ static long double T_odd(long double x)
>  #elif LDBL_MANT_DIG == 113
>  #define EXPMAN(u) ((u.i.se & 0x7fff)<<8 | u.i.top>>8)
> 
> -const long double atanhi[] = {
> +static const long double atanhi[] = {
>          4.63647609000806116214256231461214397e-01L,
>          7.85398163397448309615660845819875699e-01L,
>          9.82793723247329067985710611014666038e-01L,
>          1.57079632679489661923132169163975140e+00L,
>  };
> 
> -const long double atanlo[] = {
> +static const long double atanlo[] = {
>          4.89509642257333492668618435220297706e-36L,
>          2.16795253253094525619926100651083806e-35L,
>         -2.31288434538183565909319952098066272e-35L,
>          4.33590506506189051239852201302167613e-35L,
>  };
> 
> -const long double aT[] = {
> +static const long double aT[] = {
>          3.33333333333333333333333333333333125e-01L,
>         -1.99999999999999999999999999999180430e-01L,
>          1.42857142857142857142857142125269827e-01L,
> -- 
> 2.17.1

Your email system appears to have corrupted the patch; it does not
apply. Can you please resend as an attachment in the same git
format-patch form?

Rich


  parent reply	other threads:[~2019-04-03 14:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-03 12:56 Dan Gohman
2019-04-03 13:49 ` Szabolcs Nagy
2019-04-03 14:16 ` Rich Felker [this message]
2019-04-03 19:29   ` Dan Gohman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190403141627.GP23599@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).