From: Fangrui Song <i@maskray.me>
To: Rich Felker <dalias@libc.org>
Cc: musl@lists.openwall.com
Subject: Re: [PATCH] remove unused variables from dynlink.c
Date: Sun, 12 May 2019 22:24:08 +0800 [thread overview]
Message-ID: <20190512142408.2to3ealai3cbtbf5@gmail.com> (raw)
In-Reply-To: <20190512135418.GN23599@brightrain.aerifal.cx>
On 2019-05-12, Rich Felker wrote:
>On Sun, May 12, 2019 at 09:51:07AM -0400, Rich Felker wrote:
>> On Sun, May 12, 2019 at 09:50:50AM +0800, Fangrui Song wrote:
>> >
>> > ---
>> > ldso/dynlink.c | 1 -
>> > 1 file changed, 1 deletion(-)
>> >
>> > diff --git a/ldso/dynlink.c b/ldso/dynlink.c
>> > index 42a5470d..ad0cdba2 100644
>> > --- a/ldso/dynlink.c
>> > +++ b/ldso/dynlink.c
>> > @@ -86,7 +86,6 @@ struct dso {
>> > size_t relro_start, relro_end;
>> > uintptr_t *new_dtv;
>> > unsigned char *new_tls;
>> > - volatile int new_dtv_idx, new_tls_idx;
>> > struct td_index *td_index;
>> > struct dso *fini_next;
>> > char *shortname;
>> > --
>> > 2.21.0
>>
>> Looks ok. Your mail client seems to have corrupted the patch though;
>> git am is rejecting it for some reason. I'll apply it manually. In the
>> future if you can't get your mail client to send patches inline
>> without breaking the formatting, attachments are fine/preferred.
>
>For future reference, I found what happened: it seems to have removed
>the leading space at the beginning of the context lines (lines with no
>+ or -).
>
>Rich
Weird. I created the patch with `git format-patch --stdout -1 HEAD`,
sent an email with neomutt to myself, then resent (<esc>e) it to the
musl mailing list. Just now I checked my copy of the sent mail has the
desired leading \t.
I'll just attach a text/x-diff file next time.
next prev parent reply other threads:[~2019-05-12 14:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-12 1:50 Fangrui Song
2019-05-12 13:51 ` Rich Felker
2019-05-12 13:54 ` Rich Felker
2019-05-12 14:24 ` Fangrui Song [this message]
2019-05-12 14:31 ` Rich Felker
2019-05-12 14:48 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190512142408.2to3ealai3cbtbf5@gmail.com \
--to=i@maskray.me \
--cc=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).