From: Rich Felker <dalias@aerifal.cx>
To: musl@lists.openwall.com
Subject: Re: [PATCH 1/2] fix risc64 conflict with kernel headers
Date: Tue, 6 Aug 2019 12:31:00 -0400 [thread overview]
Message-ID: <20190806163059.GY9017@brightrain.aerifal.cx> (raw)
In-Reply-To: <63f4c551e85a848e336f41539b6dd283396eeda7.1565070674.git.baruch@tkos.co.il>
On Tue, Aug 06, 2019 at 08:51:13AM +0300, Baruch Siach wrote:
> Rename user registers struct definitions to avoid conflict with the
> asm/ptrace.h kernel header that defines the same structs. Use the
> __riscv_mc prefix as glibc does.
> ---
> arch/riscv64/bits/signal.h | 16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/arch/riscv64/bits/signal.h b/arch/riscv64/bits/signal.h
> index 4c94a8f02edc..76d7ad80c8cd 100644
> --- a/arch/riscv64/bits/signal.h
> +++ b/arch/riscv64/bits/signal.h
> @@ -12,29 +12,29 @@
> typedef unsigned long greg_t;
> typedef unsigned long gregset_t[32];
>
> -struct __riscv_f_ext_state {
> +struct __riscv_mc_f_ext_state {
> unsigned int f[32];
> unsigned int fcsr;
> };
>
> -struct __riscv_d_ext_state {
> +struct __riscv_mc_d_ext_state {
> unsigned long long f[32];
> unsigned int fcsr;
> };
>
> -struct __riscv_q_ext_state {
> +struct __riscv_mc_q_ext_state {
> unsigned long long f[64] __attribute__((aligned(16)));
> unsigned int fcsr;
> unsigned int reserved[3];
> };
>
> -union __riscv_fp_state {
> - struct __riscv_f_ext_state f;
> - struct __riscv_d_ext_state d;
> - struct __riscv_q_ext_state q;
> +union __riscv_mc_fp_state {
> + struct __riscv_mc_f_ext_state f;
> + struct __riscv_mc_d_ext_state d;
> + struct __riscv_mc_q_ext_state q;
> };
>
> -typedef union __riscv_fp_state fpregset_t;
> +typedef union __riscv_mc_fp_state fpregset_t;
>
> typedef struct sigcontext {
> gregset_t gregs;
> --
> 2.20.1
I confirmed this matches glibc. Applying.
Rich
prev parent reply other threads:[~2019-08-06 16:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 5:51 Baruch Siach
2019-08-06 5:51 ` [PATCH 2/2] fix risc64 user_regs_struct conflict with kernel header Baruch Siach
2019-08-06 12:10 ` Rich Felker
2019-08-06 12:15 ` Baruch Siach
2019-08-06 13:01 ` Rich Felker
2019-08-06 13:16 ` Szabolcs Nagy
2019-08-06 14:04 ` Rich Felker
2019-08-06 16:31 ` Rich Felker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190806163059.GY9017@brightrain.aerifal.cx \
--to=dalias@aerifal.cx \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).