From: Baruch Siach <baruch@tkos.co.il>
To: musl@lists.openwall.com
Subject: Re: [PATCH 2/2] fix risc64 user_regs_struct conflict with kernel header
Date: Tue, 06 Aug 2019 15:15:47 +0300 [thread overview]
Message-ID: <87imra7amk.fsf@tarshish> (raw)
In-Reply-To: <20190806121047.GT9017@brightrain.aerifal.cx>
Hi Rick,
On Tue, Aug 06 2019, Rich Felker wrote:
> On Tue, Aug 06, 2019 at 08:51:14AM +0300, Baruch Siach wrote:
>> Rename user_regs_struct following the example of s390 to avoid conflict
>> with the kernel asm/ptrace.h header.
>> ---
>> arch/riscv64/bits/user.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/riscv64/bits/user.h b/arch/riscv64/bits/user.h
>> index bd0f0fc7027f..097c7ad6ce18 100644
>> --- a/arch/riscv64/bits/user.h
>> +++ b/arch/riscv64/bits/user.h
>> @@ -1,4 +1,4 @@
>> -struct user_regs_struct {
>> +struct _user_regs_struct {
>> unsigned long pc;
>> unsigned long ra;
>> unsigned long sp;
>
> Does this agree with glibc naming?
glibc riscv headers do not define user_regs_struct.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
next prev parent reply other threads:[~2019-08-06 12:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-06 5:51 [PATCH 1/2] fix risc64 conflict with kernel headers Baruch Siach
2019-08-06 5:51 ` [PATCH 2/2] fix risc64 user_regs_struct conflict with kernel header Baruch Siach
2019-08-06 12:10 ` Rich Felker
2019-08-06 12:15 ` Baruch Siach [this message]
2019-08-06 13:01 ` Rich Felker
2019-08-06 13:16 ` Szabolcs Nagy
2019-08-06 14:04 ` Rich Felker
2019-08-06 16:31 ` [PATCH 1/2] fix risc64 conflict with kernel headers Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imra7amk.fsf@tarshish \
--to=baruch@tkos.co.il \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).