From: Rich Felker <dalias@libc.org>
To: musl@lists.openwall.com
Subject: Re: Patch for cacosh
Date: Tue, 1 Oct 2019 19:28:13 -0400 [thread overview]
Message-ID: <20191001232813.GG16318@brightrain.aerifal.cx> (raw)
In-Reply-To: <df809c4a40da4b46a53c4e78c1b20c75@tachyum.com>
On Tue, Oct 01, 2019 at 09:57:17PM +0000, Michael Morrell wrote:
> Running the gcc validation suite, I noticed that
> gfortran.dg/complex_intrinsic_5.f90 was failing when using MUSL.
>
> I tracked it down to the cacosh routines not getting the correct
> result when the imaginary part of the argument was negative.
>
> Attached is a patch to fix this.
Thanks!
> diff --git a/src/complex/cacosh.c b/src/complex/cacosh.c
> index 8c68cb01..0b598052 100644
> --- a/src/complex/cacosh.c
> +++ b/src/complex/cacosh.c
> @@ -4,6 +4,9 @@
>
> double complex cacosh(double complex z)
> {
> + _Bool zineg = cimag(z) < 0;
> +
I think this fails to give the desired result for negative zero.
Should probably be signbit(cimag(z)) or similar.
If there's a way to adjust the input to cacos to avoid having to patch
up after it returns based on a flag saved before the call, that would
make it more efficient I think (no need to spill/reload), but it's not
a big deal if not.
Also, as a style matter, musl codebase generally doesn't use _Bool;
rather just int for flags/boolean values.
Rich
next prev parent reply other threads:[~2019-10-01 23:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-01 21:57 Michael Morrell
2019-10-01 23:28 ` Rich Felker [this message]
2019-10-02 16:45 ` Michael Morrell
2019-10-02 11:49 ` Szabolcs Nagy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001232813.GG16318@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).