Patch for cacosh

[Michael Morrell <mmorrell@tachyum.com>]

[-- Attachment #1.1: Type: text/plain, Size: 293 bytes --]

Running the gcc validation suite, I noticed that gfortran.dg/complex_intrinsic_5.f90 was failing when using MUSL.

I tracked it down to the cacosh routines not getting the correct result when the imaginary part of the argument was negative.

Attached is a patch to fix this.

  Michael

[-- Attachment #1.2: Type: text/html, Size: 2182 bytes --]

[-- Attachment #2: cacosh.patch --]
[-- Type: application/octet-stream, Size: 1279 bytes --]

diff --git a/src/complex/cacosh.c b/src/complex/cacosh.c
index 8c68cb01..0b598052 100644
--- a/src/complex/cacosh.c
+++ b/src/complex/cacosh.c
@@ -4,6 +4,9 @@
 
 double complex cacosh(double complex z)
 {
+        _Bool zineg = cimag(z) < 0;
+
 	z = cacos(z);
-	return CMPLX(-cimag(z), creal(z));
+	if (zineg) return CMPLX(cimag(z), -creal(z));
+	else       return CMPLX(-cimag(z), creal(z));
 }
diff --git a/src/complex/cacoshf.c b/src/complex/cacoshf.c
index ade01c09..82e6c751 100644
--- a/src/complex/cacoshf.c
+++ b/src/complex/cacoshf.c
@@ -2,6 +2,9 @@
 
 float complex cacoshf(float complex z)
 {
+	_Bool zineg = cimagf(z) < 0;
+
 	z = cacosf(z);
-	return CMPLXF(-cimagf(z), crealf(z));
+	if (zineg) return CMPLXF(cimagf(z), -crealf(z));
+	else       return CMPLXF(-cimagf(z), crealf(z));
 }
diff --git a/src/complex/cacoshl.c b/src/complex/cacoshl.c
index 65342557..b0081e90 100644
--- a/src/complex/cacoshl.c
+++ b/src/complex/cacoshl.c
@@ -8,7 +8,10 @@ long double complex cacoshl(long double complex z)
 #else
 long double complex cacoshl(long double complex z)
 {
+	_Bool zineg = cimagl(z) < 0;
+
 	z = cacosl(z);
-	return CMPLXL(-cimagl(z), creall(z));
+	if (zineg) return CMPLXL(cimagl(z), -creall(z));
+	else       return CMPLXL(-cimagl(z), creall(z));
 }
 #endif