mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Petr Vorel <petr.vorel@gmail.com>
To: Rich Felker <dalias@aerifal.cx>
Cc: Szabolcs Nagy <nsz@port70.net>, musl@lists.openwall.com
Subject: Re: [RFC] fanotify_event_info_fid incompatibility
Date: Tue, 12 Nov 2019 21:30:19 +0100	[thread overview]
Message-ID: <20191112203019.GA19417@x230> (raw)
In-Reply-To: <20191112200520.GA13138@x230>

Hi,

> musl defines struct fanotify_event_info_fid member fsid as fsid_t. This
> conflicts with version from Linux kernel, which defines it as __kernel_fsid_t
> (musl's fsid_t has int __val[2], kernel's __kernel_fsid_t has int val[2]).

> I see commit 32b82cf5 ("fix the fsid_t structure to match name of __val"),
> which looks correct to me.

> I also think it's wrong, that other libc (at least glibc, uclibc-ng, bionic)
> don't define fanotify_event_info_fid and other structs thus users are forced to
> use definition from <linux/fanotify.h>. But can be something done with this
> incompatibility?

BTW this incompatibility was added quite recently, in f67b3c17 ("sys/fanotify.h:
update for linux v5.1") in v1.1.23.

Kind regards,
Petr



  reply	other threads:[~2019-11-12 20:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-12 20:05 Petr Vorel
2019-11-12 20:30 ` Petr Vorel [this message]
2019-11-12 20:46 ` Szabolcs Nagy
2019-11-12 20:58   ` Petr Vorel
2019-11-12 21:29     ` Szabolcs Nagy
2019-11-12 22:01       ` Petr Vorel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191112203019.GA19417@x230 \
    --to=petr.vorel@gmail.com \
    --cc=dalias@aerifal.cx \
    --cc=musl@lists.openwall.com \
    --cc=nsz@port70.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).