[musl] Switch to 64-bit time_t breaks strace build

[musl] Switch to 64-bit time_t breaks strace build

[Baruch Siach]

Hi musl list,

Commit 381433396 (switch all existing 32-bit archs to 64-bit time_t)
changed the IPC_STAT value on 32-bit arches from 2 to 0x102. This break
strace build time assertion of IPC_STAT value:

In file included from ./static_assert.h:11,
                 from xlat/msgctl_flags.h:4,
                 from ipc_msgctl.c:32:
xlat/msgctl_flags.h:22:1: error: static assertion failed: "IPC_STAT != 2"
 static_assert((IPC_STAT) == (2), "IPC_STAT != 2");

I that a strace bug?

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -

Re: [musl] Switch to 64-bit time_t breaks strace build

[Rich Felker]

On Thu, Mar 26, 2020 at 03:11:12PM +0200, Baruch Siach wrote:
> Hi musl list,
> 
> Commit 381433396 (switch all existing 32-bit archs to 64-bit time_t)
> changed the IPC_STAT value on 32-bit arches from 2 to 0x102. This break
> strace build time assertion of IPC_STAT value:
> 
> In file included from ./static_assert.h:11,
>                  from xlat/msgctl_flags.h:4,
>                  from ipc_msgctl.c:32:
> xlat/msgctl_flags.h:22:1: error: static assertion failed: "IPC_STAT != 2"
>  static_assert((IPC_STAT) == (2), "IPC_STAT != 2");
> 
> I that a strace bug?

Yes, it's one of the things mentioned in the time64 release notes:

https://musl.libc.org/time64.html

The upstream bug is:

https://github.com/strace/strace/issues/116

and it's fixed in:

https://github.com/strace/strace/commit/ce2c968a614ae2a3cf2354620b3b8200f003e87c

There are also some other non-build-breaking bugs with decoding of
structs, such as:

https://github.com/strace/strace/issues/122

I suspect most if not all are fixed now but I haven't checked lately.

Rich