From: Fangrui Song <i@maskray.me>
To: musl@lists.openwall.com
Subject: [musl] [PATCH] fix the symbol value for a dynamic relocation referencing a SHN_ABS symbol
Date: Thu, 2 Apr 2020 23:28:03 -0700 [thread overview]
Message-ID: <20200403062803.wmxb46mnfhwalaet@gmail.com> (raw)
fixes the example at https://sourceware.org/bugzilla/show_bug.cgi?id=19818#c3
the glibc bug also mentions dladdr() but that change seems more disruptive and
i am now sure whether/how that should be fixed.
---
ldso/dynlink.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/ldso/dynlink.c b/ldso/dynlink.c
index afec985a..6f4b50c9 100644
--- a/ldso/dynlink.c
+++ b/ldso/dynlink.c
@@ -403,7 +403,10 @@ static void do_relocs(struct dso *dso, size_t *rel, size_t rel_size, size_t stri
def.dso = dso;
}
- sym_val = def.sym ? (size_t)laddr(def.dso, def.sym->st_value) : 0;
+ sym_val = def.sym
+ ? def.sym->st_shndx == SHN_ABS ? def.sym->st_value
+ : (size_t)laddr(def.dso, def.sym->st_value)
+ : 0;
tls_val = def.sym ? def.sym->st_value : 0;
if ((type == REL_TPOFF || type == REL_TPOFF_NEG)
--
2.26.0
reply other threads:[~2020-04-03 6:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200403062803.wmxb46mnfhwalaet@gmail.com \
--to=i@maskray.me \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).