mailing list of musl libc
 help / color / mirror / Atom feed
From: Rich Felker <dalias@libc.org>
To: James Y Knight <jyknight@google.com>
Cc: musl@lists.openwall.com, "Érico Nogueira" <ericonr@disroot.org>
Subject: Re: [musl] [PATCH 2/2] include <stdc-predef.h> in <features.h>
Date: Fri, 16 Apr 2021 20:00:13 -0400
Message-ID: <20210417000012.GQ2546@brightrain.aerifal.cx> (raw)
In-Reply-To: <CAA2zVHogR51USrJkD5HgehihMki50wxkXfDdtMfp8M9WUYymRQ@mail.gmail.com>

On Fri, Apr 16, 2021 at 06:12:52PM -0400, James Y Knight wrote:
> Ugh, I thought Clang had added support for this years ago. But it looks
> like the change (https://reviews.llvm.org/D34158) never actually made it
> in; it ran into some test failures after being committed and was
> reverted, and then never reapplied. :(

The story of LLVM.. Random junk getting committed and kept, actually
important and correct changes getting reverted because of bogus tests.

Rich

> On Fri, Apr 16, 2021 at 2:51 PM Rich Felker <dalias@libc.org> wrote:
> 
> > On Fri, Apr 16, 2021 at 02:57:21PM -0300, Érico Nogueira wrote:
> > > Em 16/04/2021 11:26, Rich Felker escreveu:
> > > >On Thu, Apr 15, 2021 at 09:35:21PM -0300, Érico Nogueira wrote:
> > > >>GCC source code does contain a function to pre-include the
> > > >><stdc-predef.h> header for glibc targets, but even so glibc still
> > >
> > > I seem to have been mistaken about the feature being glibc specific;
> > using
> > >
> > >     echo "" | cc -xc - -E
> > >
> > > it seems the file does end up being included automatically.
> > >
> > > However, when using clang instead of gcc, it isn't included
> > > automatically. I don't know if this is something that clang ought to
> > > fix, is there some sort of standard about <stdc-predef.h>? Michael
> > > Forney's cproc compiler doesn't seem to touch it either.
> >
> > It's not a standard, but given that it's established I don't see any
> > reasonable argument for other compilers not to just do the same. You
> > can always fix them manually with CC="clang -include stdc-predef.h" or
> > similar though.
> >
> > > >>includes it in their own <features.h> header. furthermore, even if GCC
> > > >>implemented this for musl targets, it is still necessary for other
> > > >>compilers or previous versions of GCC.
> > > >>---
> > > >>  include/features.h | 2 ++
> > > >>  1 file changed, 2 insertions(+)
> > > >>
> > > >>diff --git a/include/features.h b/include/features.h
> > > >>index 85cfb72a..f3d53cbe 100644
> > > >>--- a/include/features.h
> > > >>+++ b/include/features.h
> > > >>@@ -1,6 +1,8 @@
> > > >>  #ifndef _FEATURES_H
> > > >>  #define _FEATURES_H
> > > >>+#include <stdc-predef.h>
> > > >>+
> > > >>  #if defined(_ALL_SOURCE) && !defined(_GNU_SOURCE)
> > > >>  #define _GNU_SOURCE 1
> > > >>  #endif
> > > >>--
> > > >>2.31.1
> > > >
> > > >I've hesitated to do this because features.h is not consistently
> > > >included from all standard headers (only if it's needed), and the
> > > >result would be inconsistent exposure of these macros. (Also
> > > >inconsistent if they're checked before any standard headers are
> > > >included, which is unfixable.) I think it makes more sense to just add
> > > >"-include stdc-predef.h" to the compiler specfile or equivalent if it
> > > >doesn't auto-include it, so that you get behavior that actually
> > > >matches the spec.
> > >
> > > Do you know if clang can use the specfile? That would make it worth
> > > it adding the entry, since GCC has the expected behavior already.
> >
> > No; specfiles are highly tied to GCC's compiler driver architecture.
> > clang might have some other equivalent mechanism though.
> >
> > Rich
> >

  reply	other threads:[~2021-04-17  0:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-16  0:35 [musl] [PATCH 1/2] define __STDC_UTF_{16,32}__ macros Érico Nogueira
2021-04-16  0:35 ` [musl] [PATCH 2/2] include <stdc-predef.h> in <features.h> Érico Nogueira
2021-04-16 14:26   ` Rich Felker
2021-04-16 17:57     ` Érico Nogueira
2021-04-16 18:51       ` Rich Felker
2021-04-16 22:12         ` James Y Knight
2021-04-17  0:00           ` Rich Felker [this message]
2021-04-17  1:56             ` James Y Knight

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210417000012.GQ2546@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=ericonr@disroot.org \
    --cc=jyknight@google.com \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

mailing list of musl libc

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.vuxu.org/musl

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V1 musl musl/ http://inbox.vuxu.org/musl \
		musl@inbox.vuxu.org
	public-inbox-index musl

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.vuxu.org/vuxu.archive.musl


code repositories for the project(s) associated with this inbox:

	https://git.vuxu.org/mirror/musl/

AGPL code for this site: git clone https://public-inbox.org/public-inbox.git