From: Alyssa Ross <hi@alyssa.is>
To: Rich Felker <dalias@libc.org>
Cc: musl@lists.openwall.com
Subject: Re: [musl] [PATCH musl v2 3/3] mntent: fix parsing lines with optional fields
Date: Sun, 15 May 2022 18:38:40 +0000 [thread overview]
Message-ID: <20220515183840.csmpbq36vd3mmhan@eve> (raw)
In-Reply-To: <20220512181553.GK7074@brightrain.aerifal.cx>
[-- Attachment #1: Type: text/plain, Size: 731 bytes --]
Hi Rich,
On Thu, May 12, 2022 at 02:15:53PM -0400, Rich Felker wrote:
> Alright. It sounds like your patch is pretty much okay as-is except
> for the added " || n[1]==len" in the while condition and removing the
> (now unreachable) return-zero condition at the end. If that sounds
> right and it's okay with you I'm happy to commit your existing patch
> with those changes then make any other improvements myself or review
> further patches from you separately if you like. What do you think?
Sounds good. Please go ahead and do it yourself —-it would take me a
fair bit of time to put my Musl development setup back together, so if
you're happy to fix up and commit the patch there's no point in me
doing that.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2022-05-15 18:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-15 22:11 [musl] [PATCH v2 0/3] Alyssa Ross
2021-09-15 22:11 ` [musl] [PATCH libc-test v2 1/3] functional: add mntent test Alyssa Ross
2021-09-15 22:11 ` [musl] [PATCH libc-test v2 2/3] functional: add mntent test for single-field line Alyssa Ross
2021-09-15 22:11 ` [musl] [PATCH musl v2 3/3] mntent: fix parsing lines with optional fields Alyssa Ross
2021-09-20 4:21 ` Rich Felker
2022-01-09 3:18 ` Rich Felker
2022-01-13 16:30 ` Alyssa Ross
2022-01-13 17:40 ` Rich Felker
2022-01-13 18:53 ` Alyssa Ross
2022-05-12 14:08 ` Rich Felker
2022-05-12 18:02 ` Alyssa Ross
2022-05-12 18:15 ` Rich Felker
2022-05-15 18:38 ` Alyssa Ross [this message]
2022-05-15 23:19 ` Rich Felker
2022-05-16 10:19 ` Alyssa Ross
2022-05-12 20:58 ` Oliver Ford
2022-05-12 21:10 ` Rich Felker
2022-05-13 21:39 ` Oliver Ford
2022-05-14 4:24 ` Rich Felker
2022-05-14 22:16 ` Oliver Ford
2022-05-15 23:31 ` Rich Felker
2022-05-16 10:07 ` Alyssa Ross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220515183840.csmpbq36vd3mmhan@eve \
--to=hi@alyssa.is \
--cc=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).