mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Rich Felker <dalias@libc.org>
To: Eugene Yudin <e.yudin@ndmsystems.com>
Cc: musl@lists.openwall.com
Subject: Re: [musl][PATCH] make clock_getcpuclockid return ESRCH rather than EINVAL
Date: Mon, 1 Aug 2022 13:55:33 -0400	[thread overview]
Message-ID: <20220801175533.GQ7074@brightrain.aerifal.cx> (raw)
In-Reply-To: <CAPmKWpH4KV0FBVpfzUgmDp7ppaX6-GQoLJ2CCg_CgUQkMxSMYg@mail.gmail.com>

On Tue, Jun 14, 2022 at 01:15:36PM +0300, Eugene Yudin wrote:
> Hi,
> 
> According to man clock_getcpuclockid() should return ESRCH if there is no
> process with the ID pid.
> 
> diff --git a/src/time/clock_getcpuclockid.c b/src/time/clock_getcpuclockid.c
> --- a/src/time/clock_getcpuclockid.c
> +++ b/src/time/clock_getcpuclockid.c
> @@ -8,6 +8,7 @@ int clock_getcpuclockid(pid_t pid, clockid_t *clk)
>         struct timespec ts;
>         clockid_t id = (-pid-1)*8U + 2;
>         int ret = __syscall(SYS_clock_getres, id, &ts);
> +       if (ret == -EINVAL) ret = -ESRCH;
>         if (ret) return -ret;
>         *clk = id;
>         return 0
> 
> The same behaviour is used in glibc:
> https://sourceware.org/git/?p=glibc.git;a=blob;f=sysdeps/unix/sysv/linux/clock_getcpuclockid.c;h=5534127ed703a3931f22af48da02e2b8f2dc39a5;hb=HEAD#l49

Thanks, applying.

Rich

      reply	other threads:[~2022-08-01 17:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-14 10:15 Eugene Yudin
2022-08-01 17:55 ` Rich Felker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220801175533.GQ7074@brightrain.aerifal.cx \
    --to=dalias@libc.org \
    --cc=e.yudin@ndmsystems.com \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).