From: "Érico Nogueira" <ericonr@disroot.org>
To: musl@lists.openwall.com
Cc: "Érico Nogueira" <ericonr@disroot.org>
Subject: [musl] [PATCH] use __getauxval in mallocng
Date: Mon, 15 Aug 2022 15:21:10 -0300 [thread overview]
Message-ID: <20220815182110.19039-1-ericonr@disroot.org> (raw)
saves around 20 bytes of .text
---
src/malloc/mallocng/glue.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/malloc/mallocng/glue.h b/src/malloc/mallocng/glue.h
index 151c48b8..4b988fb2 100644
--- a/src/malloc/mallocng/glue.h
+++ b/src/malloc/mallocng/glue.h
@@ -12,6 +12,7 @@
#include "libc.h"
#include "lock.h"
#include "dynlink.h"
+#include "sys/auxv.h"
// use macros to appropriately namespace these.
#define size_classes __malloc_size_classes
@@ -42,9 +43,8 @@
static inline uint64_t get_random_secret()
{
uint64_t secret = (uintptr_t)&secret * 1103515245;
- for (size_t i=0; libc.auxv[i]; i+=2)
- if (libc.auxv[i]==AT_RANDOM)
- memcpy(&secret, (char *)libc.auxv[i+1]+8, sizeof secret);
+ const char *at_random = (void *)__getauxval(AT_RANDOM);
+ if (at_random) memcpy(&secret, at_random+8, sizeof secret);
return secret;
}
--
2.37.2
next reply other threads:[~2022-08-15 18:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 18:21 Érico Nogueira [this message]
2022-08-15 18:31 ` Rich Felker
2022-08-15 19:01 ` Érico Nogueira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220815182110.19039-1-ericonr@disroot.org \
--to=ericonr@disroot.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).