From: "Érico Nogueira" <ericonr@disroot.org>
To: <musl@lists.openwall.com>
Subject: Re: [musl] [PATCH] use __getauxval in mallocng
Date: Mon, 15 Aug 2022 16:01:41 -0300 [thread overview]
Message-ID: <CM6U29CXJE3U.2FXQPLK0BNZ1X@mussels> (raw)
In-Reply-To: <20220815183114.GZ7074@brightrain.aerifal.cx>
On Mon Aug 15, 2022 at 3:31 PM -03, Rich Felker wrote:
> On Mon, Aug 15, 2022 at 03:21:10PM -0300, Érico Nogueira wrote:
> > saves around 20 bytes of .text
> > ---
> > src/malloc/mallocng/glue.h | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/src/malloc/mallocng/glue.h b/src/malloc/mallocng/glue.h
> > index 151c48b8..4b988fb2 100644
> > --- a/src/malloc/mallocng/glue.h
> > +++ b/src/malloc/mallocng/glue.h
> > @@ -12,6 +12,7 @@
> > #include "libc.h"
> > #include "lock.h"
> > #include "dynlink.h"
> > +#include "sys/auxv.h"
> >
> > // use macros to appropriately namespace these.
> > #define size_classes __malloc_size_classes
> > @@ -42,9 +43,8 @@
> > static inline uint64_t get_random_secret()
> > {
> > uint64_t secret = (uintptr_t)&secret * 1103515245;
> > - for (size_t i=0; libc.auxv[i]; i+=2)
> > - if (libc.auxv[i]==AT_RANDOM)
> > - memcpy(&secret, (char *)libc.auxv[i+1]+8, sizeof secret);
> > + const char *at_random = (void *)__getauxval(AT_RANDOM);
> > + if (at_random) memcpy(&secret, at_random+8, sizeof secret);
> > return secret;
> > }
> >
> > --
> > 2.37.2
>
> Hm, this might be worth doing. I'm trying to remember if there was a
> reason it wasn't done initially. It wasn't absence of a namespace-safe
> version because __getauxval already existed when mallocng was merged.
> And it doesn't look like there's an early-use issue before getauxval
> is usable either. Might it just be more expensive in the static linked
> case where __getauxval isn't otherwise used?
That does seem to be the case :/
From some quick testing, a program calling only malloc and freeing it
got ~60 bytes bigger.
I don't think there's a good way to get the best outcome in both
situations, is there? And 20 bytes in a shared mapping makes more sense.
>
> Rich
prev parent reply other threads:[~2022-08-15 19:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 18:21 Érico Nogueira
2022-08-15 18:31 ` Rich Felker
2022-08-15 19:01 ` Érico Nogueira [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CM6U29CXJE3U.2FXQPLK0BNZ1X@mussels \
--to=ericonr@disroot.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).