mailing list of musl libc
 help / color / mirror / code / Atom feed
* [musl] [PATCH] inet_pton: fix uninitialized memory use for IPv4-mapped IPv6 addresses
@ 2023-01-26 11:47 Alexey Izbyshev
  0 siblings, 0 replies; only message in thread
From: Alexey Izbyshev @ 2023-01-26 11:47 UTC (permalink / raw)
  To: musl

When a dot is encountered, the loop counter is incremented before
exiting the loop, but the corresponding ip array element is left
uninitialized, so the subsequent memmove (if "::" was seen) and the loop
copying ip to the output buffer will operate on an uninitialized

The uninitialized data never directly influences the control flow and
is overwritten on successful return by the second half of the parsed
IPv4 address. But it's better to fix this to avoid unexpected
transformations by a sufficiently smart compiler and reports from
UB-detection tools.
 src/network/inet_pton.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/network/inet_pton.c b/src/network/inet_pton.c
index d36c3689..bcbdd9ef 100644
--- a/src/network/inet_pton.c
+++ b/src/network/inet_pton.c
@@ -54,6 +54,7 @@ int inet_pton(int af, const char *restrict s, void *restrict a0)
 			if (s[j]!='.' || (i<6 && brk<0)) return 0;
+			ip[i&7]=0;
 		s += j+1;

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2023-01-26 11:48 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-26 11:47 [musl] [PATCH] inet_pton: fix uninitialized memory use for IPv4-mapped IPv6 addresses Alexey Izbyshev

Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).