From: Rich Felker <dalias@libc.org>
To: enh <enh@google.com>
Cc: musl@lists.openwall.com
Subject: Re: [musl] __riscv_flush_icache() in <sys/cachectl.h>
Date: Tue, 4 Apr 2023 19:34:34 -0400 [thread overview]
Message-ID: <20230404233434.GF4163@brightrain.aerifal.cx> (raw)
In-Reply-To: <CAJgzZoodJkRdPo1ME17XoXoCJ3tve_gOAaL957HtEuZRGPWYKg@mail.gmail.com>
On Tue, Apr 04, 2023 at 03:49:05PM -0700, enh wrote:
> i'm still trying to decide whether it makes sense to
> add __riscv_flush_icache() to bionic or not[1] and was looking to see
> whether musl had added it. i notice you've _implemented_ it but not added
> it to the <sys/cacheflush.h> header. was that deliberate or just an
> oversight?
>
> _____
> 1. see https://github.com/google/android-riscv64/issues/4 for my ramblings
> on that topic.
It's rather annoying that they added a new arch-specific header for
this rather than using the existing <sys/cachectl.h> ...
We probably need to do something to clean this up but I'm not sure
what the right action is. I figured it was usable with no header, but
apparently it needs some flags ..?
Rich
next prev parent reply other threads:[~2023-04-04 23:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 22:49 enh
2023-04-04 23:34 ` Rich Felker [this message]
2023-04-05 0:14 ` enh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230404233434.GF4163@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=enh@google.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).