From: Rich Felker <dalias@libc.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: musl@lists.openwall.com
Subject: Re: [musl] Re: [PATCH v9 0/13] implement dlmem() function (fwd)
Date: Wed, 5 Apr 2023 08:20:44 -0400 [thread overview]
Message-ID: <20230405122044.GG4163@brightrain.aerifal.cx> (raw)
In-Reply-To: <874jpule77.fsf@oldenburg.str.redhat.com>
On Wed, Apr 05, 2023 at 02:13:16PM +0200, Florian Weimer wrote:
> * Rich Felker:
>
> > Well this is disturbing. We probably need to fix gcc here (and a lot
> > of code in the wild may be broken) because musl has no such locking
> > where it doesn't belong.
>
> We have a helper function in glibc (_dl_find_object) that replaces all
> the previous object traversal logic and caching in libgcc, so it's no
> longer an issue with current gcc and glibc.
Does gcc automatically detect and use this if available? What gcc
versions does that cover? We could certainly add it, but I suspect
coverage will be incomplete... :/
> Unfortunately that means
> that the generic dl_iterate_phdr code will be fixed by adding its own
> locking.
Not sure why that's unfortunate; it's what it should have been doing
all along.
Rich
next prev parent reply other threads:[~2023-04-05 12:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 11:54 Rich Felker
2023-04-05 12:13 ` Florian Weimer
2023-04-05 12:20 ` Rich Felker [this message]
2023-04-05 12:25 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230405122044.GG4163@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=fweimer@redhat.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).