From: "Jₑₙₛ Gustedt" <jens.gustedt@inria.fr>
To: Rich Felker <dalias@libc.org>
Cc: musl@lists.openwall.com
Subject: Re: [musl] [C23 divers headers 15/17] C23: add the unreachable macro
Date: Wed, 24 May 2023 16:26:43 +0200 [thread overview]
Message-ID: <20230524162643.584eea6e@inria.fr> (raw)
In-Reply-To: <20230524142103.GV4163@brightrain.aerifal.cx>
[-- Attachment #1: Type: text/plain, Size: 1367 bytes --]
Rich,
on Wed, 24 May 2023 10:21:05 -0400 you (Rich Felker <dalias@libc.org>)
wrote:
> On Wed, Apr 19, 2023 at 08:38:04AM +0200, Jens Gustedt wrote:
> > ---
> > include/stddef.h | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/include/stddef.h b/include/stddef.h
> > index f25b8639..09be5fb6 100644
> > --- a/include/stddef.h
> > +++ b/include/stddef.h
> > @@ -24,4 +24,6 @@
> > #define offsetof(type, member) ((size_t)( (char *)&(((type
> > *)0)->member) - (char *)0 )) #endif
> >
> > +#define unreachable() __builtin_unreachable()
> > +
> > #endif
> > --
> > 2.34.1
>
> This is a namespace violation unless protected by a C version check.
That would have been my first take also. I changed these things after
you (I think it was you) telling me that generally interfaces that are
added in newer versions of C need not be protected for older
version. I probably misunderstood something. Can you please clarify
under which circumstances you want feature tests and when not?
Thanks
Jₑₙₛ
--
:: ICube :::::::::::::::::::::::::::::: deputy director ::
:: Université de Strasbourg :::::::::::::::::::::: ICPS ::
:: INRIA Nancy Grand Est :::::::::::::::::::::::: Camus ::
:: :::::::::::::::::::::::::::::::::::: ☎ +33 368854536 ::
:: https://icube-icps.unistra.fr/index.php/Jens_Gustedt ::
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
next prev parent reply other threads:[~2023-05-24 14:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 12:54 [musl] [C23 divers headers 00/17] boring header update Jens Gustedt
2023-04-15 13:21 ` [musl] [C23 divers headers 02/17] C23: Add the *_WIDTH macros to stdint.h Jens Gustedt
2023-04-17 9:09 ` [musl] [C23 divers headers 03/17] C23: add call_once to stdlib.h Jens Gustedt
2023-05-24 14:23 ` Rich Felker
2023-04-17 19:52 ` [musl] [C23 divers headers 04/17] C23: add timegm, gmtime_r and localtime_r to time.h in C23 mode Jens Gustedt
2023-04-19 6:38 ` [musl] [C23 divers headers 15/17] C23: add the unreachable macro Jens Gustedt
2023-05-24 14:21 ` Rich Felker
2023-05-24 14:26 ` Jₑₙₛ Gustedt [this message]
2023-05-24 14:30 ` Rich Felker
2023-04-19 6:42 ` [musl] [C23 divers headers 16/17] C23: add the nullptr_t type Jens Gustedt
2023-05-24 14:22 ` Rich Felker
2023-05-24 14:29 ` Jₑₙₛ Gustedt
2023-05-24 14:34 ` Rich Felker
2023-05-24 14:42 ` Jₑₙₛ Gustedt
2023-05-24 14:49 ` Rich Felker
2023-05-24 15:24 ` Jₑₙₛ Gustedt
2023-04-19 6:46 ` [musl] [C23 divers headers 17/17] C23: add the __STDC_VERSION_STDDEF_H__ macro Jens Gustedt
2023-04-19 8:16 ` [musl] [C23 divers headers 09/17] C23: update stdbool.h Jens Gustedt
2023-04-19 11:48 ` [musl] [C23 divers headers 10/17] C23: remove the contents of stdalign.h Jens Gustedt
2023-05-24 14:25 ` Rich Felker
2023-04-19 11:59 ` [musl] [C23 divers headers 11/17] C23: remove the static_assert macro Jens Gustedt
2023-04-19 12:17 ` [musl] [C23 divers headers 12/17] C23: change the assert macro to ... arguments Jens Gustedt
2023-04-19 12:48 ` [musl] [C23 divers headers 13/17] C23: add the __STDC_VERSION_ASSERT_H__ macro Jens Gustedt
2023-04-19 13:02 ` [musl] [C23 divers headers 06/17] C23: adapt setjmp.h Jens Gustedt
2023-04-19 13:11 ` [musl] [C23 divers headers 07/17] C23: change the noreturn functions in stdlib.h Jens Gustedt
2023-04-19 13:17 ` [musl] [C23 divers headers 08/17] C23: change the noreturn function in threads.h Jens Gustedt
2023-04-19 13:56 ` [musl] [C23 divers headers 14/17] C23: allow va_start to receive only one argument Jens Gustedt
2023-04-21 11:33 ` [musl] [C23 divers headers 01/17] C23: add the WIDTH macros for the standard integer types Jens Gustedt
2023-04-22 20:06 ` [musl] [C23 divers headers 05/17] C23: memccpy, strdup and strndup are now standard C Jens Gustedt
2023-05-31 9:22 [musl] [C23 divers headers 00/17] Jens Gustedt
2023-05-31 9:23 ` [musl] [C23 divers headers 15/17] C23: add the unreachable macro Jens Gustedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230524162643.584eea6e@inria.fr \
--to=jens.gustedt@inria.fr \
--cc=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).