From: Rich Felker <dalias@libc.org>
To: Yonggang Luo <luoyonggang@gmail.com>
Cc: Jens Gustedt <jens.gustedt@inria.fr>, enh <enh@google.com>,
musl@lists.openwall.com
Subject: Re: [musl] [PATCH v3 3/5] add pthread_mutex_clocklock and pthread_cond_clockdwait
Date: Wed, 21 Jun 2023 11:04:14 -0400 [thread overview]
Message-ID: <20230621150412.GL4163@brightrain.aerifal.cx> (raw)
In-Reply-To: <20230620143703.1415-4-luoyonggang@gmail.com>
On Tue, Jun 20, 2023 at 10:37:01PM +0800, Yonggang Luo wrote:
> These two functions are already implemented in glibc, android bionic libc, qnx libc
>
> Signed-off-by: Yonggang Luo <luoyonggang@gmail.com>
> ---
> compat/time32/pthread_cond_clockwait_time32.c | 9 +++++++++
> compat/time32/pthread_mutex_clocklock_time32.c | 9 +++++++++
> compat/time32/time32.h | 2 ++
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
...
> --- a/include/pthread.h
> +++ b/include/pthread.h
> [...]
>
> #if _REDIR_TIME64
> +__REDIR(pthread_mutex_clocklock, __pthread_mutex_clocklock_time64);
> __REDIR(pthread_mutex_timedlock, __pthread_mutex_timedlock_time64);
> +__REDIR(pthread_cond_clockwait, __pthread_cond_clockwait_time64);
None of this is needed. There only exist redirections and legacy
time32 functions for symbols which existed in the ABI with 32-bit
time_t. Any newly added functions are time64 from day one.
Rich
next prev parent reply other threads:[~2023-06-21 15:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-20 14:36 [musl] [PATCH v3 0/5] Add posix/pthread_mutex_clocklock posix/pthread_cond_clockdwait c2y/mtx_timedlock_base c2y/cnd_timedwait_base Yonggang Luo
2023-06-20 14:36 ` [musl] [PATCH v3 1/5] trim spaces of pthread_cond_timedwait.c and pthread_mutex_timedlock.c Yonggang Luo
2023-06-20 14:37 ` [musl] [PATCH v3 2/5] Rename files for implement pthread_mutex_clocklock and pthread_cond_clockwait Yonggang Luo
2023-06-20 14:37 ` [musl] [PATCH v3 3/5] add pthread_mutex_clocklock and pthread_cond_clockdwait Yonggang Luo
2023-06-21 15:04 ` Rich Felker [this message]
2023-06-20 14:37 ` [musl] [PATCH v3 4/5] c23: Implement newly base for timespec_get Yonggang Luo
2023-06-20 14:37 ` [musl] [PATCH v3 5/5] c2y: Add monotonic timedlock/timedwait support for threads mtx/cnd Yonggang Luo
2023-06-20 22:47 ` [musl] [PATCH v3 0/5] Add posix/pthread_mutex_clocklock posix/pthread_cond_clockdwait c2y/mtx_timedlock_base c2y/cnd_timedwait_base Rich Felker
2023-06-21 6:10 ` 罗勇刚(Yonggang Luo)
2023-06-21 14:54 ` Rich Felker
2023-06-21 18:43 ` 罗勇刚(Yonggang Luo)
2023-06-21 18:58 ` enh
2023-06-21 6:25 ` 罗勇刚(Yonggang Luo)
2023-06-21 14:44 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230621150412.GL4163@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=enh@google.com \
--cc=jens.gustedt@inria.fr \
--cc=luoyonggang@gmail.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).