From: Rich Felker <dalias@libc.org>
To: Hongliang Wang <wanghongliang@loongson.cn>
Cc: musl@lists.openwall.com
Subject: Re: [musl] add loongarch64 port v9.
Date: Thu, 16 Nov 2023 11:10:57 -0500 [thread overview]
Message-ID: <20231116161056.GZ4163@brightrain.aerifal.cx> (raw)
In-Reply-To: <7aad7a07-9762-3d62-a8c2-4cdf860a7dcb@loongson.cn>
On Thu, Nov 16, 2023 at 10:54:44AM +0800, Hongliang Wang wrote:
> Hi,
>
> Thank you for your suggestion, I have modified the dynamic linker
> name according to the basic ABI types are specified in the ABI
> document of the LoongArch, and post 0001-add-loongarch64-port-v9.patch,
> as shown in the attachment.
>
> Based on 0001-add-loongarch64-port-v8.patch,the modifications for
> 0001-add-loongarch64-port-v9.patch are as follows:
>
> ---
> arch/loongarch64/reloc.h | 10 ++++++----
> configure | 4 +++-
> 2 files changed, 9 insertions(+), 5 deletions(-)
>
> diff --git a/arch/loongarch64/reloc.h b/arch/loongarch64/reloc.h
> index a4482b48..6907de8e 100644
> --- a/arch/loongarch64/reloc.h
> +++ b/arch/loongarch64/reloc.h
> @@ -1,7 +1,9 @@
> -#ifdef __loongarch_soft_float
> -#define FP_SUFFIX "-sf"
> -#else
> -#define FP_SUFFIX ""
> +#if defined __loongarch_double_float
> +#define FP_SUFFIX "-lp64d"
> +#elif defined __loongarch_single_float
> +#define FP_SUFFIX "-lp64f"
> +#elif defined __loongarch_soft_float
> +#define FP_SUFFIX "-lp64s"
> #endif
>
> #define LDSO_ARCH "loongarch64" FP_SUFFIX
> diff --git a/configure b/configure
> index 55d179f1..93b06287 100755
> --- a/configure
> +++ b/configure
> @@ -673,7 +673,9 @@ trycppif __AARCH64EB__ "$t" && SUBARCH=${SUBARCH}_be
> fi
>
> if test "$ARCH" = "loongarch64" ; then
> -trycppif __loongarch_soft_float "$t" && SUBARCH=${SUBARCH}-sf
> +trycppif __loongarch_double_float "$t" && SUBARCH=${SUBARCH}-lp64d
> +trycppif __loongarch_single_float "$t" && SUBARCH=${SUBARCH}-lp64f
> +trycppif __loongarch_soft_float "$t" && SUBARCH=${SUBARCH}-lp64s
> printf "checking whether compiler support FCSRs... "
> echo "__asm__(\"movfcsr2gr \$t0,\$fcsr0\");" > "$tmpc"
> if $CC -c -o /dev/null "$tmpc" >/dev/null 2>&1 ; then
> --
>
> Please review again, and point them out if any questions need to be
> modified, thanks.
Why are you changing the ABI name for the existing one to something
different rather than just adding the missing ones, and doing it with
a name that's less descriptive ("-sf" is widely recognized as a
softfloat suffix, -lp64s not so much) and adding a redundant "lp64"
part to each one that does not seem to be part of distinguishing the
float ABI?
Rich
next prev parent reply other threads:[~2023-11-16 16:11 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-18 1:28 [musl] add loongarch64 port v7 王洪亮
2023-04-18 9:38 ` Szabolcs Nagy
2023-04-18 10:47 ` Szabolcs Nagy
2023-04-18 11:32 ` 王洪亮
2023-05-10 3:36 ` 王洪亮
2023-06-01 12:44 ` wanghongliang
2023-06-25 3:43 ` Hongliang Wang
2023-07-19 6:55 ` Hongliang Wang
2023-08-05 6:18 ` 翟小娟
2023-08-05 15:43 ` Rich Felker
2023-08-13 1:41 ` Rich Felker
2023-08-15 9:24 ` Hongliang Wang
2023-08-15 9:32 ` alice
2023-08-25 9:27 ` 翟小娟
[not found] ` <99d954ca-faee-2cac-97af-7fc2ecdb9a89@loongson.cn>
2023-09-20 7:45 ` Jianmin Lv
2023-09-20 13:16 ` Szabolcs Nagy
2023-09-22 1:37 ` Hongliang Wang
2023-09-26 3:28 ` [musl] add loongarch64 port v8 Hongliang Wang
2023-10-08 3:05 ` 花静云
2023-11-09 13:15 ` Jingyun Hua
2023-11-14 13:16 ` Jingyun Hua
2023-11-16 2:54 ` [musl] add loongarch64 port v9 Hongliang Wang
2023-11-16 16:10 ` Rich Felker [this message]
2023-11-17 7:20 ` Hongliang Wang
2023-11-17 17:25 ` Rich Felker
2023-11-18 4:19 ` Jingyun Hua
2023-11-20 6:11 ` Hongliang Wang
2023-12-08 8:23 ` [musl] Re:[musl] add loongarch64 port v8 Hongliang Wang
2023-12-18 7:44 ` Jingyun Hua
2024-01-29 1:26 ` [musl] " Hongliang Wang
2024-01-29 3:14 ` Rich Felker
2024-01-29 7:37 ` Hongliang Wang
2023-11-16 16:44 ` [musl] add loongarch64 port v9 Szabolcs Nagy
2023-11-16 17:18 ` Szabolcs Nagy
2023-11-17 7:19 ` Hongliang Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231116161056.GZ4163@brightrain.aerifal.cx \
--to=dalias@libc.org \
--cc=musl@lists.openwall.com \
--cc=wanghongliang@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).