From: "Sören Tempel" <soeren@soeren-tempel.net>
To: musl@lists.openwall.com
Subject: Re: [musl] [PATCH v2] cuserid: support invocation with a NULL pointer argument
Date: Wed, 29 Jan 2020 12:59:00 +0100 [thread overview]
Message-ID: <2NSST1D2CU3ZF.2X6OJSUS9Q20S@8pit.net> (raw)
In-Reply-To: <20200129112007.17575-1-soeren+git@soeren-tempel.net>
Sorry, forgot to confirm my list subscription before sending the first
version of this patch. Just wanted to reply to a comment on the previous
version:
On Tue, 28 Jan 2020, Rich Felker wrote:
> I'm not sure whether to adopt this or not, but thanks for posting on
> the list for discussion. In any case it's something we should try to
> get fixed in apps that are using it, since this is no longer portable
> usage and is gratuitously thread-unsafe.
From my personal Alpine Linux packaging perspective: I would prefer
either removing the function entirely or supporting the invocation with
a NULL pointer argument. Currently, apps using this with a NULL pointer
(e.g. cdparanoia) will crash at runtime which makes it more difficult to
identify them. If the function would be removed entirely we would be
able to detect, during compilation, which apps use it and patch them
accordingly.
Cheers,
Sören
next prev parent reply other threads:[~2020-01-29 11:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 11:20 Sören Tempel
2020-01-29 11:59 ` Sören Tempel [this message]
2020-03-22 9:51 ` Sören Tempel
2020-03-22 15:05 ` Rich Felker
2021-02-13 19:06 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2NSST1D2CU3ZF.2X6OJSUS9Q20S@8pit.net \
--to=soeren@soeren-tempel.net \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).