mailing list of musl libc
 help / color / mirror / code / Atom feed
From: "zhuyan (M)" <zhuyan34@huawei.com>
To: "musl@lists.openwall.com" <musl@lists.openwall.com>
Cc: Zengweilin <zengweilin@huawei.com>,
	"liucheng (G)" <liucheng32@huawei.com>,
	"zhuyan (M)" <zhuyan34@huawei.com>
Subject: [musl] [PATCH] fix coredump when sched_rr_get_interval parameter ts is NULL
Date: Fri, 8 May 2020 14:46:56 +0000	[thread overview]
Message-ID: <2f7471a2f0ac45f6bfc48191e16b25ec@huawei.com> (raw)
In-Reply-To: <20200508143931.5165-1-zhuyan34@huawei.com>

In function sched_rr_get_interval, there is a risk of null pointer reference. On line 12, when ts is NULL, dereferencing the null pointer will cause the program coredump.

Therefore, it must ensure that ts is not empty before use.

Signed-off-by: Yan Zhu <zhuyan34@huawei.com>
---
 src/sched/sched_rr_get_interval.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/sched/sched_rr_get_interval.c b/src/sched/sched_rr_get_interval.c
index 33a3d1a..3577291 100644
--- a/src/sched/sched_rr_get_interval.c
+++ b/src/sched/sched_rr_get_interval.c
@@ -9,6 +9,8 @@ int sched_rr_get_interval(pid_t pid, struct timespec *ts)
 		long ts32[2];
 		int r = __syscall(SYS_sched_rr_get_interval, pid, ts32);
 		if (!r) {
+			if (ts == NULL)
+				return -1;
 			ts->tv_sec = ts32[0];
 			ts->tv_nsec = ts32[1];
 		}
--
2.24.0


       reply	other threads:[~2020-05-08 14:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20200508143931.5165-1-zhuyan34@huawei.com>
2020-05-08 14:46 ` zhuyan (M) [this message]
2020-05-08 15:47   ` Markus Wichmann
2020-05-08 18:45     ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2f7471a2f0ac45f6bfc48191e16b25ec@huawei.com \
    --to=zhuyan34@huawei.com \
    --cc=liucheng32@huawei.com \
    --cc=musl@lists.openwall.com \
    --cc=zengweilin@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).