mailing list of musl libc
 help / color / mirror / code / Atom feed
From: Hydro Flask <hydroflask@yqxmail.com>
To: musl@lists.openwall.com
Cc: Rich Felker <dalias@libc.org>
Subject: Re: [musl] Potential deadlock in pthread_kill()
Date: Tue, 30 Jun 2020 14:00:13 -0700	[thread overview]
Message-ID: <300a1bdb9e9041bf05312ef032cbdc66@yqxmail.com> (raw)
In-Reply-To: <20200630195409.GH6430@brightrain.aerifal.cx>

On 2020-06-30 12:54, Rich Felker wrote:
> Note that for fixing this issue, it won't suffice just to make
> pthread_kill block signals. The other places that use the killlock
> also need to block signals, to make the lock fully AS-safe.
> 
> Rich

Rich did you see the issue I was talking about in the example in my 
previous email? Does it make sense?

I do not mind submitting a patch for this issue if you don't currently 
have the spare cycles, just let me know if we are in agreement in terms 
of understanding the issue and I can submit a patch that blocks "app 
signals" in every place that uses the killlock.

Probably could also remove the pthread_self() special case that you 
referenced earlier in the thread but that would be a second patch.

Thank you,
Hydro

  reply	other threads:[~2020-06-30 21:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-30  4:19 Hydro Flask
2020-06-30  4:43 ` Rich Felker
2020-06-30  6:19   ` Hydro Flask
2020-06-30  9:26     ` Rich Felker
2020-06-30 14:58       ` Markus Wichmann
2020-06-30 16:28         ` Hydro Flask
2020-06-30 19:28           ` Dmitry Samersoff
2020-06-30 19:54             ` Rich Felker
2020-06-30 21:00               ` Hydro Flask [this message]
2020-07-06 22:00                 ` Rich Felker
2020-07-06 22:14                   ` Hydro Flask
2020-07-06 22:22                     ` Rich Felker
2020-07-06 22:37                       ` Hydro Flask

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=300a1bdb9e9041bf05312ef032cbdc66@yqxmail.com \
    --to=hydroflask@yqxmail.com \
    --cc=dalias@libc.org \
    --cc=musl@lists.openwall.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).