mailing list of musl libc
 help / color / mirror / code / Atom feed
From: pengyuanhong <pengyuanhong@huawei.com>
To: "musl@lists.openwall.com" <musl@lists.openwall.com>
Cc: helitao <helitao@huawei.com>,
	"Huangqiang (H)" <h.huangqiang@huawei.com>,
	Jinyongming <jinyongming@huawei.com>,
	leijitang <leijitang@huawei.com>,
	"liuyutao (C)" <liuyutao2@huawei.com>,
	"Liyu (Marvin, Euler Dept)" <marvin.tms@huawei.com>,
	"Threefifteen Wang(Kunfeng)"
	<threefifteen.wangkunfeng@huawei.com>,
	"Wudilong (Michael)" <wudilong@huawei.com>
Subject: [proposal] Add detection of thread ID in pthread-related interfaces
Date: Tue, 11 Jun 2019 11:36:59 +0000	[thread overview]
Message-ID: <4CF320752F2B99449115298D4A06B22F34E3DD31@dggemm509-mbx.china.huawei.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 668 bytes --]

Hello,

I find that all pthread-related interfaces directly access the input
parameter `pthread_t` without any check. If I pass an invalid thread ID
(e.g. an exited thread ID) to these interfaces, then segment fault
happens.

Both glibc and freebsd can do simple detection of thread ID(pthread_t)
passed by user and return ESRCH when no thread can be found. They
put all threads in a list or hash table, and update this list or table every
time a thread is created or exits.

From the user's point of view, segment fault is unbearable and is not
*         recoverable in most cases. Instead, returning an error of ESRCH
*         seems more acceptable.

[-- Attachment #2: Type: text/html, Size: 7202 bytes --]

             reply	other threads:[~2019-06-11 11:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-11 11:36 pengyuanhong [this message]
2019-06-11 13:57 ` Szabolcs Nagy
2019-06-11 14:36   ` Rich Felker
2019-06-11 15:58     ` Li Yu
2019-06-11 16:15       ` Rich Felker
2019-06-11 16:09 ` Rich Felker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CF320752F2B99449115298D4A06B22F34E3DD31@dggemm509-mbx.china.huawei.com \
    --to=pengyuanhong@huawei.com \
    --cc=h.huangqiang@huawei.com \
    --cc=helitao@huawei.com \
    --cc=jinyongming@huawei.com \
    --cc=leijitang@huawei.com \
    --cc=liuyutao2@huawei.com \
    --cc=marvin.tms@huawei.com \
    --cc=musl@lists.openwall.com \
    --cc=threefifteen.wangkunfeng@huawei.com \
    --cc=wudilong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.vuxu.org/mirror/musl/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).