From: "Daniel Kolesa" <daniel@octaforge.org>
To: "David Miller" <davem@davemloft.net>,
musl@lists.openwall.com, dalias@libc.org
Cc: AWilcox@Wilcox-Tech.com, netdev@vger.kernel.org,
linux-api@vger.kernel.org
Subject: Re: [musl] Re: [PATCH] uapi: Prevent redefinition of struct iphdr
Date: Thu, 26 Dec 2019 12:13:37 +0100 [thread overview]
Message-ID: <66db73b0-c470-4708-a017-c662f4ca0d7c@www.fastmail.com> (raw)
In-Reply-To: <20191225.194929.1465672299217213413.davem@davemloft.net>
On Thu, Dec 26, 2019, at 04:49, David Miller wrote:
> From: Rich Felker <dalias@libc.org>
> Date: Wed, 25 Dec 2019 20:05:15 -0500
>
> > On Wed, Dec 25, 2019 at 04:34:11PM -0800, David Miller wrote:
> >> I find it really strange that this, therefore, only happens for musl
> >> and we haven't had thousands of reports of this conflict with glibc
> >> over the years.
> >
> > It's possible that there's software that's including just one of the
> > headers conditional on __GLIBC__, and including both otherwise, or
> > something like that. Arguably this should be considered unsupported
> > usage; there are plenty of headers where that doesn't work and
> > shouldn't be expected to.
>
> I don't buy that, this is waaaaaay too common a header to use.
In case of net-tools, only <linux/ip.h> is included, and never <netinet/ip.h> directly. Chances are in musl the indirect include tree happens to be different and conflicting, while in glibc it is not.
>
> Please investigate.
>
Daniel
next prev parent reply other threads:[~2019-12-26 11:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-22 6:02 A. Wilcox
2019-12-26 0:34 ` David Miller
2019-12-26 1:05 ` Rich Felker
2019-12-26 3:49 ` [musl] " David Miller
2019-12-26 11:13 ` Daniel Kolesa [this message]
2019-12-30 17:12 ` Rich Felker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66db73b0-c470-4708-a017-c662f4ca0d7c@www.fastmail.com \
--to=daniel@octaforge.org \
--cc=AWilcox@Wilcox-Tech.com \
--cc=dalias@libc.org \
--cc=davem@davemloft.net \
--cc=linux-api@vger.kernel.org \
--cc=musl@lists.openwall.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).