From: Samuel Holland <samuel@sholland.org>
To: musl@lists.openwall.com, Rich Felker <dalias@libc.org>
Subject: Re: [PATCH 0/2] Resolve compiler warnings in master
Date: Sat, 29 Jun 2019 18:05:31 -0500 [thread overview]
Message-ID: <770e0f26-83d0-de0d-a48d-818c3aaccbbe@sholland.org> (raw)
In-Reply-To: <20190629214622.GN1506@brightrain.aerifal.cx>
On 6/29/19 4:46 PM, Rich Felker wrote:
> On Sat, Jun 29, 2019 at 04:22:42PM -0500, Samuel Holland wrote:
>> These two patches resolve some compiler warnings about mismatched
>> attributes and restrict violations. There's another warning, related
>> to duplicate definitions of TIOCSER_TEMT on some arches; I'm not sure
>> which header needs to be changed. It results in:
>>
>> ../include/sys/ioctl.h:47: warning: "TIOCSER_TEMT" redefined
>>
>> The definitions are:
>>
>> arch/mips/bits/termios.h:#define TIOCSER_TEMT 0x01
>> arch/mips64/bits/termios.h:#define TIOCSER_TEMT 0x01
>> arch/mipsn32/bits/termios.h:#define TIOCSER_TEMT 0x01
>> arch/powerpc/bits/termios.h:#define TIOCSER_TEMT 0x01
>> arch/powerpc64/bits/termios.h:#define TIOCSER_TEMT 0x01
>> include/sys/ioctl.h:#define TIOCSER_TEMT 1
>
> I don't see how this is happening with a consistent tree. Commit
> 3517d74a5e04a377192d1f4882ad6c8dc22ce69a removed it from the bits
> headers.
That commit removed it from bits/ioctl.h. The definition is still in
bits/termios.h, where it was changed in 9eda4dc69c33852c97c6f69176bf45ffc80b522f
to match the old value in bits/ioctl.h. So maybe sys/ioctl.h needs to be changed
from 1 to 0x01?
Cheers,
Samuel
prev parent reply other threads:[~2019-06-29 23:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-29 21:22 Samuel Holland
2019-06-29 21:22 ` [PATCH 1/2] resolve -Wrestrict warnings Samuel Holland
2019-06-29 21:22 ` [PATCH 2/2] use the correct attributes for ___errno_location Samuel Holland
2019-06-29 21:49 ` Rich Felker
2019-06-29 21:46 ` [PATCH 0/2] Resolve compiler warnings in master Rich Felker
2019-06-29 23:05 ` Samuel Holland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=770e0f26-83d0-de0d-a48d-818c3aaccbbe@sholland.org \
--to=samuel@sholland.org \
--cc=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).