From: Florian Weimer <fweimer@redhat.com>
To: Rich Felker <dalias@libc.org>
Cc: Olivier Galibert <galibert@pobox.com>, musl@lists.openwall.com
Subject: Re: [musl] [PATCH] arm64/sigcontext: Synchronize the type of the __reserved field with the linux kernel.
Date: Thu, 19 Aug 2021 07:54:12 +0200 [thread overview]
Message-ID: <878s0y2d4r.fsf@oldenburg.str.redhat.com> (raw)
In-Reply-To: <20210819004903.GN13220@brightrain.aerifal.cx> (Rich Felker's message of "Wed, 18 Aug 2021 20:49:03 -0400")
* Rich Felker:
> On Thu, Aug 19, 2021 at 12:52:23AM +0200, Olivier Galibert wrote:
>> clang's compiler-rt sanitizer_linux.cpp expects the __reserved field
>> to be convertible to u8 *. So let's.
>> ---
>> arch/aarch64/bits/signal.h | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/aarch64/bits/signal.h b/arch/aarch64/bits/signal.h
>> index 5098c734..a46997e3 100644
>> --- a/arch/aarch64/bits/signal.h
>> +++ b/arch/aarch64/bits/signal.h
>> @@ -19,7 +19,7 @@ typedef struct sigcontext {
>> unsigned long fault_address;
>> unsigned long regs[31];
>> unsigned long sp, pc, pstate;
>> - long double __reserved[256];
>> + unsigned char __reserved[4096] __attribute__((__aligned__(16)));
>> } mcontext_t;
>>
>> #define FPSIMD_MAGIC 0x46508001
>
> The member name __reserved is not API, much less its particular type.
The name is called __reserved, but it is actually part of the API.
We learned this when we tried to rename it:
<https://sourceware.org/bugzilla/show_bug.cgi?id=22742>
The name and its __ prefix are rather unfortunate, but we are stuck with
it.
Thanks,
Florian
next prev parent reply other threads:[~2021-08-19 5:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 22:52 Olivier Galibert
2021-08-19 0:49 ` Rich Felker
2021-08-19 5:54 ` Florian Weimer [this message]
2021-08-19 13:38 ` Rich Felker
2021-08-20 6:46 ` Szabolcs Nagy
2021-11-07 7:07 ` Fangrui Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878s0y2d4r.fsf@oldenburg.str.redhat.com \
--to=fweimer@redhat.com \
--cc=dalias@libc.org \
--cc=galibert@pobox.com \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).