From: Jeffrey Walton <firstname.lastname@example.org>
Subject: Re: [musl] [PATCH] Use __builtin_FILE/__builtin_LINE if available
Date: Tue, 21 Feb 2023 14:45:28 -0500 [thread overview]
Message-ID: <CAH8yC8kjzb3_g0t5OmKrN03nNdY9iRd68kVy4j4Uz0Y5BNk5gg@mail.gmail.com> (raw)
On Sat, Feb 18, 2023 at 7:17 AM Jon Chesterfield
> On Sat, 18 Feb 2023, 02:54 Fangrui Song, <email@example.com> wrote:
> On Fri, Feb 17, 2023 at 6:03 PM Rich Felker <firstname.lastname@example.org> wrote:
> > On Fri, Feb 17, 2023 at 05:33:33PM -0800, Fangrui Song wrote:
> > > C++ inline functions are requred to have exact same sequence of tokens
> > > in every translation unit, but __FILE__ and __LINE__ may expand to
> > > different tokens. The ODR violatioin is usually benign, but it can lead
> > > to errors when C++20 modules are used.
> It is sad that C++ modules broke 'assert' but not surprising. Modules were largely created out of aversion to macros. This isn't something libc can fix though, I suggest a defect report against C++ instead.
Somewhat related, I tried contacting the C/C++ committee to have
concerns addressed several years ago. I was not able to reach the
committee. There's no mailing list or discussion group available to
the public at large. It looks like one of those groups where the
committee only talks with the companies that build compilers.
Outsiders (like compiler users) are not welcomed.
> Changing the semantics of assert in C seems like a bad thing to do.
prev parent reply other threads:[~2023-02-21 19:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-18 1:33 Fangrui Song
2023-02-18 2:03 ` Rich Felker
2023-02-18 2:53 ` Fangrui Song
2023-02-18 12:17 ` Jon Chesterfield
2023-02-21 19:09 ` Fangrui Song
2023-02-27 22:26 ` Szabolcs Nagy
2023-03-02 8:19 ` Fangrui Song
[not found] ` <DS7PR12MB57655F44D45FF7D0B9BB01C5CBB29@DS7PR12MB5765.namprd12.prod.outlook.com>
2023-03-05 3:23 ` Zhihao Yuan
2023-08-30 22:04 ` Fangrui Song
2023-02-21 19:45 ` Jeffrey Walton [this message]
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).