From: enh <enh@google.com>
To: dalias@libc.org
Cc: musl@lists.openwall.com
Subject: Re: [musl] SA_RESTORER for rv64?
Date: Thu, 10 Nov 2022 09:26:47 -0800 [thread overview]
Message-ID: <CAJgzZop_7APE-U7WtWbAnjPkdbKJLPKEOcwgK9mtH_eN4Tt4kw@mail.gmail.com> (raw)
In-Reply-To: <20221110171858.GJ29905@brightrain.aerifal.cx>
[-- Attachment #1: Type: text/plain, Size: 834 bytes --]
On Thu, Nov 10, 2022 at 9:19 AM Rich Felker <dalias@libc.org> wrote:
> On Thu, Nov 10, 2022 at 07:44:23AM -0800, enh wrote:
> > arch/riscv64/bits/signal.h has contained a definition for SA_RESTORER
> since
> > the initial commit, but i think that's just copy & paste from whichever
> > architecture the rv64 headers were based on? the linux kernel itself
> > doesn't have SA_RESTORER for rv64, unless i'm missing something?
>
> I suspect this is just a mistake. Have you seen any ill effects from
> it? If riscv folks can confirm it's wrong, I'll remove it.
>
i noticed this by inspection after someone had some code that (correctly)
didn't compile with bionic or glibc but did with musl. in addition to
rejecting the proposal to add a rv64 SA_RESTORER to bionic, i said i'd
reach out to musl about removing it there :-)
> Rich
>
[-- Attachment #2: Type: text/html, Size: 1371 bytes --]
next prev parent reply other threads:[~2022-11-10 17:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-10 15:44 enh
2022-11-10 17:18 ` Rich Felker
2022-11-10 17:26 ` enh [this message]
2022-11-10 17:31 ` Khem Raj
2023-02-03 18:44 ` enh
2023-02-05 23:54 ` Rich Felker
2023-02-06 16:51 ` enh
2023-02-06 17:49 ` Rich Felker
2023-02-08 21:45 ` Rich Felker
2023-02-08 21:53 ` enh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJgzZop_7APE-U7WtWbAnjPkdbKJLPKEOcwgK9mtH_eN4Tt4kw@mail.gmail.com \
--to=enh@google.com \
--cc=dalias@libc.org \
--cc=musl@lists.openwall.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.vuxu.org/mirror/musl/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).